Add a wasm:: prefix to JITted function symbols#10
Open
Mrmaxmeier wants to merge 2 commits intofgsect:mainfrom
Open
Add a wasm:: prefix to JITted function symbols#10Mrmaxmeier wants to merge 2 commits intofgsect:mainfrom
wasm:: prefix to JITted function symbols#10Mrmaxmeier wants to merge 2 commits intofgsect:mainfrom
Conversation
Sancov seems to generate calls to memcpy sometimes (?), so let's make sure the symbol is available
Re-using the module's function names as symbols is nice for debugging, but can be fatal when they overlap with WAVM's runtime. This commonly happens when a WASM module includes functions like `memset` or `memcpy`, and leads to confusing segfaults.
Collaborator
|
Oh, good catch, that one! Have you tried by chance if the function blocklisting still works? |
Author
Hm right, this probably breaks function filters. I'm not sure what the best fix is then. There might be a way to tell the linker/loader that WASM symbols shouldn't be resolved/preferred outside of the module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-using the module's function names as symbols is nice for debugging but can be fatal when they overlap with WAVM's runtime symbols.
This happens for WASM modules that include functions like
memsetormemcpyand leads to confusing segfaults.