refactor: Unpack errors in tests#16
Merged
alanshaw merged 1 commit intoMay 26, 2026
Merged
Conversation
This was referenced May 22, 2026
Merged
For expected errors, this confirms that we find the correct error. For unexpected errors, this makes the error message visible in the test failure.
Peeja
force-pushed
the
petra/refactor/unpack-errors-with-binding
branch
from
d042656 to
daae365
Compare
alanshaw
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For expected errors, this confirms that we find the correct error. For unexpected errors, this makes the error message visible in the test failure.
Some of these were already unpacking, but now they use the
.Unpack()from the command binding instead of doing more work to recreate the same thing.PR Dependency Tree
bindingcommands fromlibforge#17This tree was auto-generated by Charcoal