Add remainingLockup to settlement events and emit when no funds sent - #16
Closed
bajtos wants to merge 1 commit into
Closed
Add remainingLockup to settlement events and emit when no funds sent#16bajtos wants to merge 1 commit into
bajtos wants to merge 1 commit into
Conversation
Update CDNSettlement and CacheMissSettlement events to include a remainingLockup parameter showing lockup available after settlement. Events are now emitted even when settledAmount is 0 (no usage or zero lockup), but not for uninitialized datasets or when no rail configured. This allows consumers to track lockup state without separate queries to the Payments contract. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Contributor
Author
|
I won't have the bandwidth to continue working on this pull request. Feel free to take my code and open a new pull request to finish the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CDNSettlement and CacheMissSettlement events to include a remainingLockup parameter showing lockup available after settlement.
Events are now emitted even when settledAmount is 0 (no usage or zero lockup), but not for uninitialized datasets or when no rail configured.
This allows consumers to track lockup state without separate queries to the Payments contract.
Note: I don't have an immediate need for this new information as I found a viable work-around for now. I think this new information is something we may need in the future, so I want the new events to be included in the next contract version deployment.
Refs: