WIP: Add "1st clocked in" to status line#206
Open
jzsampaio wants to merge 1 commit intofilipelbc:masterfrom
Open
WIP: Add "1st clocked in" to status line#206jzsampaio wants to merge 1 commit intofilipelbc:masterfrom
jzsampaio wants to merge 1 commit intofilipelbc:masterfrom
Conversation
filipelbc
reviewed
Feb 25, 2019
| _overall_time_spent += time_spent | ||
|
|
||
| if statussing and not verbose: | ||
| first_entry = logbook[0] |
Owner
There was a problem hiding this comment.
This may not be the actual first entry because the logbook variable comes from the filtered data which may not contain all logbook entries.
So you need to either make sure this is never the case (with tests?) or take this from the unfiltered data.
filipelbc
reviewed
Feb 25, 2019
| string += "\n %s %s." % (_ce('Clocked out at'), dt2str(log['out'])) | ||
| else: | ||
| string += "%s %s." % (_cf('Clocked in at'), dt2str(log['in'])) | ||
| string += "\n %s %s." % (_cf('Clocked in at'), dt2str(log['in'])) |
Owner
There was a problem hiding this comment.
Instead of manually breaking lines, I think it would be better to call _write.
Owner
|
Should printing this line be a option exposed in the cli interface? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flagged as WIP because I've not updated the test files.
Whenever I'm pushing hours to Gitlab, I find it useful to know what was the 1st clocked in date.
Since the status line became too big, I've split it into 3. Sample below.