-
Notifications
You must be signed in to change notification settings - Fork 651
feat(py): add pysentry-rs security scanning to hooks and CI #4273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's security posture by introducing pysentry-rs for automated Python dependency vulnerability scanning. The integration ensures that security checks are performed both during local development through git hooks and as part of the continuous integration process, providing early detection of known vulnerabilities and improving overall code quality and reliability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great addition, integrating pysentry-rs for automated security scanning of Python dependencies into local development hooks and the CI pipeline. The implementation is solid, with a new configuration file for pysentry-rs and integration into the existing linting and testing workflow. I have a couple of suggestions for the new wrapper script to improve its robustness and consistency with other scripts in the repository.
Integrates pysentry-rs for automated security auditing of Python dependencies. This setup ensures that known vulnerabilities are detected during local development (via git hooks) and in CI. - Add pysentry-rs to the lint dependency group in pyproject.toml - Create py/bin/run_python_security_checks wrapper script - Add py/.pysentry.toml with configuration and audit rules - Integrate security checks into captainhook.json (pre-commit/pre-push) - Insert security scan step into .github/workflows/python.yml - Suppress known nbconvert and protobuf vulnerabilities awaiting fix ISSUE: none CHANGELOG: - [ ] Add pysentry-rs for automated Python dependency security auditing - [ ] Integrate Python security scanning into pre-commit/pre-push hooks and CI
bc3c64e to
e18a4d5
Compare
Integrates pysentry-rs for automated security auditing of Python dependencies. This setup ensures that known vulnerabilities are detected during local development (via git hooks) and in CI. - Add pysentry-rs to the lint dependency group in pyproject.toml - Create py/bin/run_python_security_checks wrapper script - Add py/.pysentry.toml with configuration and audit rules - Integrate security checks into captainhook.json (pre-commit/pre-push) - Insert security scan step into .github/workflows/python.yml - Suppress known nbconvert and protobuf vulnerabilities awaiting fix ISSUE: none CHANGELOG: - [ ] Add pysentry-rs for automated Python dependency security auditing - [ ] Integrate Python security scanning into pre-commit/pre-push hooks and CI
Integrates pysentry-rs for automated security auditing of Python
dependencies. This setup ensures that known vulnerabilities are
detected during local development (via git hooks) and in CI.
ISSUE: none
CHANGELOG: