-
Notifications
You must be signed in to change notification settings - Fork 648
feat(py): implement Genkit class methods and registry for feature parity #4274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly advances the Genkit Python SDK by bringing its core Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
534e76c to
3cab5b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several core methods to the Genkit class and expands registry capabilities, bringing the Python SDK closer to feature parity with the JavaScript implementation. Key additions include Genkit.current_context(), Genkit.run(), Genkit.flush_tracing(), Genkit.check_operation(), and define_simple_retriever. The GoogleAI and VertexAI plugins have also been updated to support optional api_version and base_url configurations. The changes are well-tested with comprehensive unit tests for the new APIs. Overall, the changes are well-structured and enhance the SDK's functionality significantly.
3cab5b0 to
625e083
Compare
|
/gemini review |
This commit enhances the Genkit Python SDK by implementing several core methods in the Genkit class and expanding registry capabilities to better align with the canonical JavaScript implementation. ISSUE: N/A CHANGELOG: - Added Genkit.current_context(), Genkit.run(), Genkit.flush_tracing(), and Genkit.check_operation() to the Genkit class. - Implemented define_simple_retriever supporting flexible content and metadata mapping for easy integration of existing data sources. - Added Genkit.dynamic_tool() for creating unregistered tool actions passed directly to generation calls. - Updated GoogleAI and VertexAI plugins to support optional api_version and base_url configuration. - Enhanced registry management and action resolution logic within the Genkit instance. - Added comprehensive unit tests for the updated Genkit API, including retriever mapping and tracing flush logic.
625e083 to
33e92ef
Compare
|
/gemini review |
This commit enhances the Genkit Python SDK by implementing several core
methods in the Genkit class and expanding registry capabilities to
better align with the canonical JavaScript implementation.
ISSUE: N/A
CHANGELOG:
and Genkit.check_operation() to the Genkit class.
metadata mapping for easy integration of existing data sources.
passed directly to generation calls.
and base_url configuration.
Genkit instance.
retriever mapping and tracing flush logic.