Skip to content

genesis: replacing fd types genesis type with handrolled one #7565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ibhatt-jumptrading wants to merge 5 commits into
base: main
Choose a base branch
from
Open

genesis: replacing fd types genesis type with handrolled one #7565

ibhatt-jumptrading wants to merge 5 commits into from

Conversation

@ibhatt-jumptrading
Copy link
Contributor

@ibhatt-jumptrading ibhatt-jumptrading commented Dec 5, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.064161 s 0.063927 s -0.365% ✅
backtest mainnet-368528500-perf snapshot load 2.356 s 2.347 s -0.382% ✅
backtest mainnet-368528500-perf total elapsed 64.160678 s 63.927318 s -0.364% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.050907 s 0.050884 s -0.045% ✅
backtest mainnet-368528500-perf snapshot load 1.644 s 1.628 s -0.973% ✅
backtest mainnet-368528500-perf total elapsed 50.907125 s 50.883981 s -0.045% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.074457 s 0.073667 s -1.061% ✅
backtest mainnet-368528500-perf snapshot load 3.179 s 3.166 s -0.409% ✅
backtest mainnet-368528500-perf total elapsed 74.456822 s 73.666834 s -1.061% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.063367 s 0.064094 s 1.147% ✅
backtest mainnet-368528500-perf snapshot load 2.331 s 2.368 s 1.587% ✅
backtest mainnet-368528500-perf total elapsed 63.367473 s 64.094113 s 1.147% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.063789 s 0.064377 s 0.922% ✅
backtest mainnet-368528500-perf snapshot load 2.371 s 2.329 s -1.771% ✅
backtest mainnet-368528500-perf total elapsed 63.788845 s 64.377121 s 0.922% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

@ibhatt-jumptrading ibhatt-jumptrading changed the title genesis: replacing fd types genesis type with handrolled one [wip, don't review] genesis: replacing fd types genesis type with handrolled one Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.073297 s 0.073966 s 0.913% ✅
backtest mainnet-368528500-perf snapshot load 3.143 s 3.18 s 1.177% ✅
backtest mainnet-368528500-perf total elapsed 73.296846 s 73.965832 s 0.913% ✅
firedancer mem usage with mainnet.toml 1023.23 GiB 1023.23 GiB 0.000% ✅

ripatel-fd
ripatel-fd requested changes Dec 7, 2025
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we accept genesis blobs from remote peers this needs some more security measures. Could you add a fuzz_genesis_parse.c with a generic libfuzzer harness? You can check the gossip message parser fuzzer for a scaffold and the in-tree docs for libFuzzer build instructions.

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.050837 s 0.05078 s -0.112% ✅
backtest mainnet-368528500-perf snapshot load 1.613 s 1.638 s 1.550% ✅
backtest mainnet-368528500-perf total elapsed 50.837211 s 50.78034 s -0.112% ✅
firedancer mem usage with mainnet.toml 1011.23 GiB 1011.23 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.050799 s 0.050881 s 0.161% ✅
backtest mainnet-368528500-perf snapshot load 1.623 s 1.596 s -1.664% ✅
backtest mainnet-368528500-perf total elapsed 50.798526 s 50.880533 s 0.161% ✅
firedancer mem usage with mainnet.toml 1011.23 GiB 1011.23 GiB 0.000% ✅

ripatel-fd
ripatel-fd reviewed Dec 15, 2025
View reviewed changes
ripatel-fd
ripatel-fd requested changes Dec 15, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.051175 s 0.050919 s -0.500% ✅
backtest mainnet-368528500-perf snapshot load 1.631 s 1.621 s -0.613% ✅
backtest mainnet-368528500-perf total elapsed 51.17453 s 50.918706 s -0.500% ✅
firedancer mem usage with mainnet.toml 1005.23 GiB 1005.23 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.051022 s 0.050895 s -0.249% ✅
backtest mainnet-368528500-perf snapshot load 1.616 s 1.619 s 0.186% ✅
backtest mainnet-368528500-perf total elapsed 51.021844 s 50.894741 s -0.249% ✅
firedancer mem usage with mainnet.toml 1005.23 GiB 1005.23 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.050502 s 0.050553 s 0.101% ✅
backtest mainnet-368528500-perf snapshot load 1.618 s 1.597 s -1.298% ✅
backtest mainnet-368528500-perf total elapsed 50.502357 s 50.553367 s 0.101% ✅
firedancer mem usage with mainnet.toml 1005.23 GiB 1005.23 GiB 0.000% ✅

@github-actions
Copy link

github-actions bot commented Dec 16, 2025

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.050389 s 0.050417 s 0.056% ✅
backtest mainnet-368528500-perf snapshot load 1.618 s 1.615 s -0.185% ✅
backtest mainnet-368528500-perf total elapsed 50.388546 s 50.416558 s 0.056% ✅
firedancer mem usage with mainnet.toml 1005.23 GiB 1005.23 GiB 0.000% ✅

ripatel-fd
ripatel-fd reviewed Dec 17, 2025
View reviewed changes
src/discof/replay/fd_replay_tile.c
Comment on lines 1271 to 1273
// TODO: Do not pass the fd_types type between tiles, it have offsets
// that are unsafe and can't be validated as being in-bounds. Need to
// pass an actual owned genesis type.
Copy link
Contributor

@ripatel-fd ripatel-fd Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this comment

ripatel-fd
ripatel-fd approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ripatel-fd ripatel-fd ripatel-fd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ibhatt-jumptrading @ripatel-fd