simd-0332: reduce chacha rounds for turbine from 20 to 8 #7597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0ece
requested review from
alpeng-jump,
anwayde,
jherrera-jump,
mmcgee-jump and
ptaffet-jump
as code owners
0x0ece
force-pushed
the
0x0ece/chacha8
branch
from
ba0c3f0 to
1ce4731
Compare
0x0ece
force-pushed
the
0x0ece/chacha8
branch
from
b83b9ea to
04bc6f5
Compare
ripatel-fd
previously approved these changes
Dec 17, 2025
0x0ece
force-pushed
the
0x0ece/chacha8
branch
from
04bc6f5 to
4c145eb
Compare
0x0ece
force-pushed
the
0x0ece/chacha8
branch
3 times, most recently
from
8450f33 to
61b972b
Compare
0x0ece
commented
Dec 18, 2025
| #define SORT_NAME sort_pubkey | ||
| #define SORT_KEY_T fd_shred_dest_weighted_t | ||
| #define SORT_BEFORE(a,b) (memcmp( (a).pubkey.uc, (b).pubkey.uc, 32UL )<0) | ||
| #define SORT_BEFORE(a,b) (memcmp( (a).pubkey.uc, (b).pubkey.uc, 32UL )>0) |
Contributor
Author
There was a problem hiding this comment.
I believe this is a bug...
0x0ece
force-pushed
the
0x0ece/chacha8
branch
from
61b972b to
8ac86fe
Compare
Performance Measurements ⏳
|
ripatel-fd
reviewed
Dec 18, 2025
| } | ||
|
|
||
| /* ============================================================================ | ||
| RUST REFERENCE IMPLEMENTATION |
Contributor
There was a problem hiding this comment.
Should probably move to contrib and make it an actual .rs file so we can compile and run it
ripatel-fd
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agave: anza-xyz/agave#7353