Skip to content

Conversation

@twangodev
Copy link
Collaborator

@twangodev twangodev commented Nov 13, 2025

Should be the final PR before we launch v1.0.0 :)

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/fishaudio/__init__.py 100.00% <100.00%> (ø)
src/fishaudio/client.py 91.42% <ø> (ø)
src/fishaudio/core/client_wrapper.py 48.88% <100.00%> (ø)
src/fishaudio/core/iterators.py 100.00% <100.00%> (ø)
src/fishaudio/resources/tts.py 94.69% <100.00%> (+0.51%) ⬆️
src/fishaudio/types/account.py 100.00% <ø> (ø)
src/fishaudio/types/asr.py 100.00% <ø> (ø)
src/fishaudio/types/shared.py 100.00% <100.00%> (ø)
src/fishaudio/types/tts.py 100.00% <ø> (ø)
src/fishaudio/types/voices.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@twangodev twangodev marked this pull request as ready for review November 14, 2025 01:59
Copilot AI review requested due to automatic review settings November 14, 2025 01:59
Copilot finished reviewing on behalf of twangodev November 14, 2025 02:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the Fish Audio Python SDK for the v1.0.0 release with significant API improvements and breaking changes.

Key Changes

  • API Refactoring: Renamed convert() method to stream() for streaming operations, introduced new convert() method that returns complete audio as bytes
  • New Audio Stream Wrappers: Added AudioStream and AsyncAudioStream classes with .collect() utility method
  • Environment Variable Rename: Changed from FISH_AUDIO_API_KEY to FISH_API_KEY across all code, tests, and documentation
  • Enhanced Documentation: Added comprehensive docstrings for all type classes with detailed attribute descriptions
  • Development Status Update: Upgraded package classifier from "Beta" to "Production/Stable"

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/fishaudio/core/iterators.py New file introducing AudioStream/AsyncAudioStream wrappers with collection utilities
src/fishaudio/resources/tts.py Refactored TTS client: added stream() method, converted convert() to return bytes
src/fishaudio/core/client_wrapper.py Updated environment variable from FISH_AUDIO_API_KEY to FISH_API_KEY
src/fishaudio/client.py Updated docstrings to reference new FISH_API_KEY environment variable
src/fishaudio/init.py Exported new AudioStream and AsyncAudioStream classes
src/fishaudio/types/*.py Added comprehensive attribute documentation to all model classes
tests/unit/test_tts.py Updated tests to use new stream() method and handle bytes-returning convert()
tests/unit/test_core.py Updated environment variable in tests
tests/unit/test_client.py Updated environment variable in tests
tests/integration/*.py Updated to use new convert() API returning bytes instead of iterators
tests/integration/conftest.py Modified save_audio helper to accept both bytes and list[bytes]
pyproject.toml Updated development status classifier to Production/Stable
examples/*.py Updated all examples to use new FISH_API_KEY environment variable
README.md Complete rewrite with updated API examples and environment variable
scripts/copy_docs.py Changed SDK documentation title from "Python SDK" to "Overview"
.github/workflows/python.yml Updated CI environment variable
.env.example Updated environment variable name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@twangodev twangodev merged commit 88ac9b5 into main Nov 14, 2025
22 checks passed
@twangodev twangodev deleted the chore/v1 branch November 14, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants