Skip to content

fix: Image layer paint area fix #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: Image layer paint area fix #3783

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bc996f
Use image size instead of canvas
ufrshubham Feb 17, 2024
851e6ad
Merge branch 'main' into devkage/image-layer-paint-area-fix
ufrshubham Feb 17, 2024
ba6881e
Merge branch 'main' into devkage/image-layer-paint-area-fix
ufrshubham Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions packages/flame_tiled/lib/src/renderable_layers/image_layer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ class FlameImageLayer extends RenderableLayer<ImageLayer> {
final Image _image;
late final ImageRepeat _repeat;
final MutableRect _paintArea = MutableRect.fromLTRB(0, 0, 0, 0);
final Vector2 _canvasSize = Vector2.zero();
final Vector2 _maxTranslation = Vector2.zero();

FlameImageLayer({
Expand All @@ -29,9 +28,7 @@ class FlameImageLayer extends RenderableLayer<ImageLayer> {
}

@override
void handleResize(Vector2 canvasSize) {
_canvasSize.setFrom(canvasSize);
}
void handleResize(Vector2 canvasSize) {}

@override
void render(Canvas canvas, CameraComponent? camera) {
Expand Down Expand Up @@ -81,18 +78,18 @@ class FlameImageLayer extends RenderableLayer<ImageLayer> {
if (_repeat == ImageRepeat.repeatX || _repeat == ImageRepeat.repeat) {
final xImages = (_maxTranslation.x / _image.size.x).ceil();
_paintArea.left = -_image.size.x * xImages;
_paintArea.right = _canvasSize.x + _image.size.x * xImages;
_paintArea.right = _image.size.x * xImages;
} else {
_paintArea.left = 0;
_paintArea.right = _canvasSize.x;
_paintArea.right = _image.size.x;
}
if (_repeat == ImageRepeat.repeatY || _repeat == ImageRepeat.repeat) {
final yImages = (_maxTranslation.y / _image.size.y).ceil();
_paintArea.top = -_image.size.y * yImages;
_paintArea.bottom = _canvasSize.y + _image.size.y * yImages;
_paintArea.bottom = _image.size.y * yImages;
} else {
_paintArea.top = 0;
_paintArea.bottom = _canvasSize.y;
_paintArea.bottom = _image.size.y;
}
}

Expand Down