Skip to content

docs: Fix dead gamepads and Yarn Spinner links - #4235

Merged
ufrshubham merged 1 commit into
flame-engine:mainfrom
farisbasha:docs-dead-gamepads-yarn-links
Nov 17, 2026
Merged

ufrshubham merged 1 commit into
flame-engine:mainfrom
farisbasha:docs-dead-gamepads-yarn-links

Conversation

@farisbasha

Copy link
Copy Markdown
Contributor

Description

Two links in the docs return 404:

  • doc/bridge_packages/flame_gamepads/flame_gamepads.md: the gamepads library link points to https://github.com/flame-engine/gamepads.dart, which does not exist. The library lives at https://github.com/flame-engine/gamepads.
  • doc/other_modules/jenny/language/language.md: the "official documentation" link for the YarnSpinner language points to https://docs.yarnspinner.dev/getting-started/writing-in-yarn, which was removed when Yarn Spinner reorganised its docs. It now points to the language section, https://docs.yarnspinner.dev/write-yarn-scripts/scripting-fundamentals.

Checked with curl: both old URLs return 404, both new ones return 200. Only the link targets changed.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

None.

@ufrshubham
ufrshubham merged commit 9c354dd into flame-engine:main Nov 17, 2026
9 checks passed
LordixDemon added a commit to LordixDemon/flame that referenced this pull request Nov 17, 2026
Brings in the upstream fix for findPostProcessFromContext (flame-engine#4221), the
package skills (flame-engine#4223) and documentation link fixes (flame-engine#4234, flame-engine#4235).

The only conflict was in post_process_component.dart: the fork's own
lookup through CameraComponent.currentCamera is replaced by upstream's
walk over CameraComponent.currentCameras, and the camera import that
the upstream version no longer needs is dropped.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants