Repository navigation
docs: Fix dead gamepads and Yarn Spinner links - #4235
Merged
ufrshubham merged 1 commit intoNov 17, 2026
Merged
Conversation
ufrshubham
approved these changes
Nov 17, 2026
LordixDemon
added a commit
to LordixDemon/flame
that referenced
this pull request
Nov 17, 2026
Brings in the upstream fix for findPostProcessFromContext (flame-engine#4221), the package skills (flame-engine#4223) and documentation link fixes (flame-engine#4234, flame-engine#4235). The only conflict was in post_process_component.dart: the fork's own lookup through CameraComponent.currentCamera is replaced by upstream's walk over CameraComponent.currentCameras, and the camera import that the upstream version no longer needs is dropped. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two links in the docs return 404:
doc/bridge_packages/flame_gamepads/flame_gamepads.md: thegamepadslibrary link points tohttps://github.com/flame-engine/gamepads.dart, which does not exist. The library lives athttps://github.com/flame-engine/gamepads.doc/other_modules/jenny/language/language.md: the "official documentation" link for the YarnSpinner language points tohttps://docs.yarnspinner.dev/getting-started/writing-in-yarn, which was removed when Yarn Spinner reorganised its docs. It now points to the language section,https://docs.yarnspinner.dev/write-yarn-scripts/scripting-fundamentals.Checked with curl: both old URLs return 404, both new ones return 200. Only the link targets changed.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
None.