-
Notifications
You must be signed in to change notification settings - Fork 0
Fixes #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
moshloop
wants to merge
54
commits into
main
Choose a base branch
from
fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes #44
Changes from all commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
c2340ad
feat: proper rendering of api.Text and Textable in all formatters
moshloop b1a9880
feat: refactor formatters to use FieldValue.Text and PrettyData.Pretty()
moshloop 57b2bb0
chore: misc
moshloop b3522ce
chore: update examples
moshloop 173d6df
fix: restore table rendering temporarily, fix ANSI test checks
moshloop da8ab64
fix: wrap string values in Text for TextList compatibility
moshloop 123cd14
fix: add missing types and methods for compilation
moshloop 37919a6
refactor: remove Formatted(), Plain(), Markdown(), HTML() from FieldV…
moshloop 21f9e44
fix: update test to handle Textable interface properly
moshloop 774ad88
wip
moshloop 50e1326
misc
moshloop dc3936e
fix: improve HTML tree rendering with embedded assets
moshloop d563f5f
refactor: extract inline CSS/JS to go:embed files and use Iconify che…
moshloop a0cf374
fix: align tree chevrons to top
moshloop 6cef77f
fix: use interface assertion in NewTypedValue for nested trees
moshloop fdfee78
feat: implement nested table rendering in HTML with compact support
moshloop f205a3a
feat(ai): add LLM agent adapter with structured output support
moshloop afd2e3c
fix(task): prevent hanging and terminal corruption in task manager
moshloop 12ddad5
fix(task): resolve race conditions in batch.go
moshloop e686a55
fix(task): resolve data races in Task and Manager
moshloop 094b57b
fix: formatting improvements
moshloop 94c8cd2
fix: args handling in clicky.AddCommand
moshloop 5a78548
chore: ai refactorings
moshloop f54969b
fix: batch race conditions
moshloop 33f6988
fix: parse max-w unit suffixes (ch, px, rem, em)
moshloop dd79195
feat: default to truncate-suffix when constraints specified
moshloop 10436ec
fix: prevent truncate class from overwriting explicit max-w
moshloop b229f73
feat: migrate terminal tables to lipgloss (hybrid approach)
moshloop 1653eff
feat: migrate tree rendering to lipgloss
moshloop c587b42
chore: switch tree/table printing back to lipgloss
moshloop 13947dc
chore: fix nested html table output
moshloop 0266e5d
chore: fix nested html tree output
moshloop 2e45834
chore: html fixes
moshloop ddf7c70
chore: uber demo
moshloop 7cd3b7e
chore: fix lint errors
moshloop a25d6e3
chore: review fixes
moshloop 56006ce
chore: fix test errors
moshloop ac5681c
feat(formatters): make TextTable self-contained with column schema
moshloop 86c09a4
fix(html): add fallback to data.Tree for tree fields
moshloop f0ade9f
refactor(html): use Value() + type switch instead of GetValue()
moshloop 7d6de30
chore: refactor formatters package
moshloop 0d9dd0e
chore: refactor formatters package
moshloop 7efdaf9
refactor(table): make lipgloss table Textable-aware
moshloop 40058f0
chore: html table fixes
moshloop 5aeb357
feat: batch timeouts
moshloop 7cafb26
fix: check PrettyRow interface before extracting struct fields
moshloop c619bc2
fix: duplicate rendering of logs with --no-progress
moshloop dfdf7df
fix: formatting tests
moshloop 970bbb4
fix: reset capture output when reusing exec wrappers
moshloop 8bf74ec
chore: fix tests
moshloop 32d5261
chore: fix formatting tests
moshloop 1506311
fix: batch timeouts
moshloop 8d62c85
chore: test / logging improvements
moshloop 9aec737
Merge branch 'main' of https://github.com/flanksource/clicky into dev
moshloop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: flanksource/clicky
Length of output: 2794
🏁 Script executed:
Repository: flanksource/clicky
Length of output: 4872
🏁 Script executed:
Repository: flanksource/clicky
Length of output: 2572
🏁 Script executed:
Repository: flanksource/clicky
Length of output: 11910
Critical: Undefined
loggeridentifier breaks compilation at line 175.The code references
logger.GetSlogLogger().WithSkipReportLevel(1).Errorf(...)butloggeris not defined anywhere in scope—not imported, not passed as a parameter, and not available in theRunEcallback context. This is a compilation error that blocks the build.Recommended fixes:
Remove the logging line (simplest):
Use the options parameter if it implements logger.Logger:
Accept a logger in a callback parameter (requires API change).
🧰 Tools
🪛 GitHub Actions: Lint
[error] 175-175: golangci-lint: undefined: logger (typecheck)
🪛 GitHub Actions: PR #44
[error] 175-175: build failed: undefined: logger
🪛 GitHub Actions: Test
[error] 175-175: golangci-lint: undefined: logger (typecheck)
🪛 GitHub Check: golangci-lint
[failure] 175-175:
undefined: logger (typecheck)
🪛 GitHub Check: Lint
[failure] 175-175:
undefined: logger (typecheck)
🪛 GitHub Check: Test (ubuntu-latest, Go 1.25)
[failure] 175-175:
undefined: logger
🤖 Prompt for AI Agents