-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add guided tour #3051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yashmehrotra
wants to merge
6
commits into
main
Choose a base branch
from
tour
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add guided tour #3051
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
02b8191
feat: add guided tour
yashmehrotra 509e6b3
chore: playbook + views tour
yashmehrotra 41b42fd
fix: add icons + playbook modal highlight
yashmehrotra 4385438
chore: add checklist
yashmehrotra 5444bf9
chore: better naming
yashmehrotra 7e59736
chore: update playbook view name
yashmehrotra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // ABOUTME: Reads and records person_touchpoints — the checklist actions a user has completed. | ||
| // ABOUTME: Upserts on (person_id, key) via merge-duplicates so re-doing an action is idempotent. | ||
| import { IncidentCommander } from "../axios"; | ||
| import { resolvePostGrestRequestWithPagination } from "../resolve"; | ||
|
|
||
| export type PersonTouchpoint = { | ||
| person_id: string; | ||
| key: string; | ||
| }; | ||
|
|
||
| export function fetchPersonTouchpoints(personId: string) { | ||
| return resolvePostGrestRequestWithPagination<Pick<PersonTouchpoint, "key">[]>( | ||
| IncidentCommander.get( | ||
| `/person_touchpoints?person_id=eq.${personId}&select=key` | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| export function recordPersonTouchpoint(personId: string, key: string) { | ||
| return IncidentCommander.post( | ||
| "/person_touchpoints", | ||
| { person_id: personId, key }, | ||
| { headers: { Prefer: "resolution=merge-duplicates,return=minimal" } } | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Guard
redirect_browser_tobefore assigningwindow.location.hrefBoth branches now allow
undefinedto flow intowindow.location.href. If Kratos returns a partial payload, this can trigger incorrect navigation rather than a controlled fallback. Add a null check (and fallback route/reset) before redirecting.Suggested fix
case "session_refresh_required": // We need to re-authenticate to perform this action - window.location.href = err.response?.data?.redirect_browser_to; + if (err.response?.data?.redirect_browser_to) { + window.location.href = err.response.data.redirect_browser_to; + return; + } + resetFlow(undefined); + await router.push("/" + flowType); return; @@ case "browser_location_change_required": // Ory Kratos asked us to point the user to this URL. - window.location.href = err.response?.data?.redirect_browser_to; + if (err.response?.data?.redirect_browser_to) { + window.location.href = err.response.data.redirect_browser_to; + return; + } + resetFlow(undefined); + await router.push("/" + flowType); return;Also applies to: 85-85
🤖 Prompt for AI Agents