Open
Conversation
akundaz
requested review from
0x416e746f6e,
SozinM,
avalonche and
karim-agha
as code owners
avalonche
reviewed
Mar 12, 2026
| /// Time offset we used for first flashblock | ||
| pub first_flashblock_time_offset: Histogram, | ||
| /// Delay in milliseconds between expected and actual FCU arrival time (positive = late, negative = early) | ||
| pub fcu_arrival_delay: Histogram, |
Collaborator
There was a problem hiding this comment.
whats the difference between this metric and flashblocks_time_drift? can you reuse that or rename it?
Contributor
Author
There was a problem hiding this comment.
That metric isn't being recorded at all right now :/
Collaborator
There was a problem hiding this comment.
then we can remove flashblocks_time_drift?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good to record this since I'm suspecting with the op-node hotfix this could be less jittery but higher on average