Skip to content

Conversation

@RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Nov 12, 2025

Issues

FE part of #35654
Closes #35638
Closes #35557

Description

  • Display display_name across app
  • Show display_name correctly in edit icon modal after adding
  • Update FE interfaces not to have display_name nested in software.app_store_app or software.software_package
  • Allow clicking on a tooltip link

Note: There are API fixes as well that Jahziel is doing that will make some of these display names properly show

Testing

  • QA'd all new/changed functionality manually

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.24%. Comparing base (0b3f9bb) to head (464daae).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
.../DashboardPage/cards/ActivityFeed/ActivityFeed.tsx 0.00% 7 Missing ⚠️
.../hosts/details/HostDetailsPage/HostDetailsPage.tsx 0.00% 3 Missing ⚠️
...ftwareDetailsModal/LibrarySoftwareDetailsModal.tsx 0.00% 1 Missing ⚠️
...eed/components/VPPDetailsModal/VppDetailsModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #35668      +/-   ##
==========================================
- Coverage   66.24%   66.24%   -0.01%     
==========================================
  Files        2104     2104              
  Lines      178307   178316       +9     
  Branches     7387     7399      +12     
==========================================
+ Hits       118122   118126       +4     
- Misses      49364    49369       +5     
  Partials    10821    10821              
Flag Coverage Δ
frontend 53.72% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RachelElysia
Copy link
Member Author

Planning to wrap up and ensure I added all unreleased fixes in the AM

@RachelElysia RachelElysia marked this pull request as ready for review November 13, 2025 15:24
@RachelElysia RachelElysia requested a review from a team as a code owner November 13, 2025 15:24
@RachelElysia RachelElysia merged commit 9b7f7ce into main Nov 13, 2025
15 checks passed
@RachelElysia RachelElysia deleted the 4.77-unreleased-fe-4 branch November 13, 2025 17:06
RachelElysia added a commit that referenced this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants