-
-
Notifications
You must be signed in to change notification settings - Fork 48
Implement highlighting based on user badges #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4bcbade to
1a7c620
Compare
app/src/main/kotlin/com/flxrs/dankchat/data/repo/HighlightsRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/flxrs/dankchat/data/repo/HighlightsRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/flxrs/dankchat/data/repo/HighlightsRepository.kt
Show resolved
Hide resolved
app/src/main/kotlin/com/flxrs/dankchat/preferences/notifications/highlights/HighlightsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/flxrs/dankchat/preferences/notifications/highlights/HighlightsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/flxrs/dankchat/data/repo/HighlightsRepository.kt
Outdated
Show resolved
Hide resolved
flex3r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice initial work, some comments and feedback
1a7c620 to
5d09c0f
Compare
5d09c0f to
d24325f
Compare
flex3r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
Let me know if you would like to have a "contributor" badge btw
Sure. I'm also achow101 on twitch. |
This PR implements highlighting of messages based on the badges of a user, similar to one of Chatterino's options. The default set of badge highlights are Broadcaster, Admin, Staff, Moderator, Verified, VIP, Founder, and Subscriber. The colors chosen for the highlights are default colors from Chatterino that are similar colors to each badge's main color. The exceptions are Founder and Subscriber which do not have a custom color but rather use the default mention highlight color. The default set are not highlighted by default, but are made available in the settings so that users can enable them if they want.
Users can also provide their own badge matching strings to get any such messages highlighted with the default mention color. But these strings are not very intuitive which is why I included the default set.
Closes #453