Repository navigation
Updates shrubbery to 0.3 - #54
Merged
Merged
Conversation
I replaced the separate `TagType`, `TagIndex`, and `TypeAtIndex` constraints on response codes with shrubbery's new `LookupTag` family. It finds a status code's index and type in a single pass, which cuts compilation overhead for handlers with many response codes.
telser
requested changes
Sep 30, 2026
telser
left a comment
telser
left a comment
Contributor
There was a problem hiding this comment.
I think we should pin the shrubbery version in the package.yaml/cabal since this ties to 0.3+ versions pretty hard now, right?
Member
Author
|
Good point, done in 821711a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced the separate
TagType,TagIndex, andTypeAtIndexconstraints on response codes with shrubbery's new
LookupTagfamily.It finds a status code's index and type in a single pass, which cuts
compilation overhead for handlers with many response codes.