fix: use correct localization key for external source setting#710
Merged
sadespresso merged 1 commit intoflow-mn:developfrom Apr 21, 2026
Merged
Conversation
The code used `preferences.transactions.listTile.transactionListTileShowExternalSource` but the localization files use `preferences.transactions.listTile.showExternalSource`. Fixes flow-mn#708
PawiX25
force-pushed
the
fix/wrong-localization-key-external-source
branch
from
1663a73 to
bfde3f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the wrong localization key used for the "Show external sources" toggle in the list tile appearance preferences page.
Problem
The code referenced
preferences.transactions.listTile.transactionListTileShowExternalSourcebut the localization files (en.jsonand all language files) define the key aspreferences.transactions.listTile.showExternalSource. This caused the raw key to be displayed instead of translated text in all languages.Changes
transaction_list_item_appearance_preferences_page.dartfromtransactionListTileShowExternalSourcetoshowExternalSourceFixes #708