fix: stabilize preview transaction dates in settings#711
Merged
sadespresso merged 1 commit intoflow-mn:developfrom Apr 21, 2026
Merged
Conversation
Move example transaction generation to `didChangeDependencies()` so they're created once and reused across rebuilds. Use `Random(42)` with a fixed seed to produce deterministic dates. Previously, toggling any setting called `setState()` which regenerated the preview transactions with new random dates, causing the displayed times to jump. Fixes flow-mn#709
PawiX25
force-pushed
the
fix/preview-transaction-random-dates
branch
from
3c85d0e to
0236c1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes preview transaction dates randomly changing every time a setting is toggled in the list tile appearance preferences.
Problem
getExampleTransactions()was called insidebuild()and usedRandom().nextInt(1000)(unseeded). EverysetState()triggered by toggling a switch would regenerate the example transactions with new random dates, causing the preview times to visibly jump.Changes
didChangeDependencies()(needscontextfor the category name localization)late finalfield so they're created once per page visitRandom(42)(fixed seed) for deterministic preview datesFixes #709