feat(charts): adding extraDeploy key for additional k8s objects#1789
Open
sc250024 wants to merge 1 commit intofluxcd:mainfrom
Open
feat(charts): adding extraDeploy key for additional k8s objects#1789sc250024 wants to merge 1 commit intofluxcd:mainfrom
sc250024 wants to merge 1 commit intofluxcd:mainfrom
Conversation
Author
|
Nevermind |
sc250024
force-pushed
the
feat-extra-manifests
branch
from
dc4beae to
e210655
Compare
This adds an `extraDeploy` key to the chart, enabling users to attach additional Kubernetes manifests to the deployment as needed Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
sc250024
force-pushed
the
feat-extra-manifests
branch
from
e210655 to
b3b8682
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
extraDeploykey to the chart, enabling users to attach additional Kubernetes manifests to the deployment as needed. Theextra-deploy.yamlandrenderfunction were lifted from the Bitnami charts, which do the same thing.The reasoning for this is that my company uses a CRD linked with Backstage for ownership over certain components in Kubernetes. For owning this resource, we would need to deploy extra templates alongside this component.