Draft
Conversation
Add benchmark for recurseKustomizationFiles() to measure the performance of recursively loading kustomization files with certain percentage of symlinks in the kustomizations. Signed-off-by: Sunny <darkowlzz@protonmail.com>
pjbgf
reviewed
May 3, 2022
| return nil | ||
| } | ||
|
|
||
| b.StartTimer() |
Member
There was a problem hiding this comment.
Do we want to also report on allocs so we can grasp the impact as the code changes?
Suggested change
| b.StartTimer() | |
| b.StartTimer() | |
| b.ReportAllocs() |
pjbgf
reviewed
May 3, 2022
Member
pjbgf
left a comment
There was a problem hiding this comment.
great initiative @darkowlzz, looking forward to some benchmarks across the project. 🚀 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add benchmark for
recurseKustomizationFiles()to measure the performanceof recursively loading kustomization files with certain percentage of
symlinks in the kustomizations.
Follow up of #619 .
Benchmark results for 10/100/1000/10000 kustomization nodes and 10/80 % of them
as symlinks: