Add DirectSourceFetch feature gate to bypass cache for source objects#314
Merged
matheuscscp merged 1 commit intofluxcd:mainfrom Feb 15, 2026
Merged
Add DirectSourceFetch feature gate to bypass cache for source objects#314matheuscscp merged 1 commit intofluxcd:mainfrom
DirectSourceFetch feature gate to bypass cache for source objects#314matheuscscp merged 1 commit intofluxcd:mainfrom
Conversation
dipti-pai
force-pushed
the
direct-source-fetch
branch
from
8fb42eb to
bd0d480
Compare
matheuscscp
approved these changes
Feb 14, 2026
Member
matheuscscp
left a comment
matheuscscp
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Just a tiny fix in a comment
| case sourcev1.ExternalArtifactKind: | ||
| var chart sourcev1.ExternalArtifact | ||
| err := r.Get(ctx, namespacedName, &chart) | ||
| var ea sourcev1.ExternalArtifact |
This feature gate enables fetching source objects (GitRepository, OCIRepository, Bucket) directly from the API server using APIReader, bypassing the controller's cache. This can be useful when immediate consistency is required for source object reads. When enabled via --feature-gates=DirectSourceFetch=true: Source objects are fetched using r.APIReader instead of r.Client A log message is emitted at startup indicating the feature is active Changes: Add DirectSourceFetch field to ArtifactGeneratorReconciler struct Update getSource() to use APIReader when feature is enabled Add internal/features package with feature gate definitions Register feature gate with default value false (opt-in) Add unit tests for sources Update pkg/runtime dependency to v0.100.1 Signed-off-by: Dipti Pai <diptipai89@outlook.com>
dipti-pai
force-pushed
the
direct-source-fetch
branch
from
bd0d480 to
9b1cf78
Compare
stefanprodan
changed the title
DirectSourceFetch feature gate to bypass cache for source objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature gate enables fetching source objects (GitRepository, OCIRepository, Bucket) directly from the API server using APIReader, bypassing the controller's cache. This can be useful when immediate consistency is required for source object reads.
When enabled via --feature-gates=DirectSourceFetch=true:
Source objects are fetched using r.APIReader instead of r.Client A log message is emitted at startup indicating the feature is active Changes:
Add DirectSourceFetch field to ArtifactGeneratorReconciler struct
Update getSource() to use APIReader when feature is enabled
Add internal/features package with feature gate definitions
Register feature gate with default value false (opt-in)
Add unit tests for sources
Update pkg/runtime dependency to v0.100.1
Part of : fluxcd/kustomize-controller#1583