Find catkin before invoking catkin_package()#9
Open
spmaniato wants to merge 2 commits intofmrchallenge:mainfrom
Open
Find catkin before invoking catkin_package()#9spmaniato wants to merge 2 commits intofmrchallenge:mainfrom
spmaniato wants to merge 2 commits intofmrchallenge:mainfrom
Conversation
Member
|
My plan is to merge the code that was used for evaluation at ICRA 2016 and then to consider this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes to the dubins traffic ROS packages'
CMakeLists.txtfiles. I think you've been depending on other packages findingcatkin, whichcatkin_makeallows. With these fixes, you can also build withcatkin(aka catkin_tools)I'm not as confident about the
dubins_traffic_utilschange because there's some extra logic there.