[WIP/ENH] - Add model comparison functionality#409
Open
TomDonoghue wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a procedure for applying and comparing multiple models on the same data, with the new
ModelComparisonobject.The basic idea of
ModelComparisonis an object that holds multiple Model objects, that each share the same data object, but have different algorithm / mode / results sub-objects - so that a series of different model definitions can be applied to the same data together. The results can then be plotted together for comparison.Notes:
ModelComparisonforSpectralModelobjects. This could be extended to supportSpectralGroupModelobjects, to fit and compare results across groups of spectra (?)