Patch imagemagick-stream for Node 24 compatibility - #70
Merged
Conversation
imagemagick-stream@4.1.1's error handler calls util.isError(), which was removed from Node.js core. On Node 24 this throws "TypeError: isError is not a function" every time ImageMagick emits any error output, masking the real underlying failure and crashing instead of emitting a normal 'error' event on the stream. The package has been unmaintained since 2018, so patch it in place via patch-package (already used in this repo for liftup). Fixes plait PLAIT-BACKEND-947
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imagemagick-stream@4.1.1's error handler callsutil.isError(), which was removed from Node.js core. On Node 24 this throwsTypeError: isError is not a functionevery time ImageMagick emits any error output — masking the real underlying failure and crashing instead of emitting a normalerrorevent on the stream.patch-package(already used in this repo forliftup).plait(branchfix/sentry-error-cleanup) andplaitapp-services(also loads this package directly).Fixes plait PLAIT-BACKEND-947.
Test plan
npm install/postinstallapplies the patch cleanlyErrorsurfaces instead of theisErrorcrash🤖 Generated with Claude Code