Fix team card blurb overflow and stripe z-index#14
Merged
nchalla3 merged 3 commits intoformulaslug:mainfrom Feb 24, 2026
Merged
Fix team card blurb overflow and stripe z-index#14nchalla3 merged 3 commits intoformulaslug:mainfrom
nchalla3 merged 3 commits intoformulaslug:mainfrom
Conversation
Two bugs on the team page subteam cards: - Blurb text falling off the bottom: caused by mt-10 on the h1 inside a flex items-center container, which pushed the text below the card boundary. Removed the margin. - Stripe decoration cutting off blurb text: the absolute-positioned stripe divs paint after normal block elements in CSS stacking order, rendering on top of the blurb h1. Fixed by adding relative z-10 to the h1 so it always renders above the stripe layer. Closes formulaslug#9 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The deploy condition only checked for fork PRs, but push events to a fork repo also lack secrets. Replaced the event-based fork check with a direct secrets.FIREBASE_TOKEN != '' guard, which correctly skips the preview deploy in any context where secrets are unavailable (fork repos, fork PRs, or unconfigured repos) and shows an explanatory notice instead of failing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…crets context secrets.* is not available as an if: condition context in GitHub Actions steps. Replace the secrets check with a dedicated 'Check Firebase credentials' step that reads the token via env and writes available=true/false to its output. Subsequent deploy steps gate on steps.creds.outputs.available == 'true'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mt-10from the blurbh1inside the subteam card flip side — this margin was pushing text down past the card boundary in aflex items-centercontainerrelative z-10to the blurbh1so it renders above the absolute-positioned stripe decorations, which were painting on top of the text (affected Outreach, HV, Ergo, Manufacturing, Suspension)secrets.*inif:conditions, which GitHub Actions does not supportCloses #9
Test plan
🤖 Generated with Claude Code