Skip to content

feat(enext): unify event page #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 14, 2025
Merged

feat(enext): unify event page #1223

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
98f0d60
unify event page
Gagan-Ram Nov 10, 2025
1dd861b
retain top margin
Gagan-Ram Nov 11, 2025
f1541df
work on sourcery suggestion
Gagan-Ram Nov 11, 2025
57efd2d
Merge branch 'enext' into 1079_unify_event_page
mariobehling Nov 11, 2025
6af0274
rename and change cfp path
Gagan-Ram Nov 12, 2025
90638cd
copilot suggestions and create fragment_nav.html
Gagan-Ram Nov 12, 2025
44b73f1
place video button to right
Gagan-Ram Nov 12, 2025
6827661
Merge branch 'enext' into 1079_unify_event_page
mariobehling Nov 12, 2025
79f3261
copilot suggestions and remove inline css
Gagan-Ram Nov 13, 2025
bf54aef
Merge branch 'enext' into 1079_unify_event_page
mariobehling Nov 14, 2025
38d388d
copilot -2
Gagan-Ram Nov 13, 2025
1431218
show sessions, speakers, schedule only if present
Gagan-Ram Nov 14, 2025
989c2d0
remove nested selectors in .css
Gagan-Ram Nov 14, 2025
9824a85
dropdown reorder
Gagan-Ram Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions app/eventyay/agenda/templates/agenda/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@
{% endblock nav_link %}

{% block header_tabs %}
{% comment %} <a href="{}" class="header-tab">
<i class="fa fa-info-circle"></i> {% translate "Info" %}
</a> {% endcomment %}
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented-out code rather than leaving it in the codebase. If this Info tab feature might be needed in the future, document it in an issue or task tracker instead.

Suggested change
{% comment %} <a href="{}" class="header-tab">
<i class="fa fa-info-circle"></i> {% translate "Info" %}
</a> {% endcomment %}

Copilot uses AI. Check for mistakes.
Copy link
Member

@hongquan hongquan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow this.

<a href="{% url 'presale:event.index' event=request.event.slug organizer=request.event.organizer.slug %}" class="header-tab">
<i class="fa fa-ticket"></i> {% translate "Tickets" %}
</a>
{% if schedule or request.event.current_schedule %}
<a href="{{ request.event.urls.schedule }}" class="header-tab {% if "/schedule/" in request.path_info %}active{% endif %}">
<i class="fa fa-calendar"></i> {{ phrases.schedule.schedule }}
Expand All @@ -44,11 +50,15 @@
<i class="fa fa-link"></i> {{ link.label }}
</a>
{% endfor %}
{% if request.event.display_settings.ticket_link %}
<a href="{{ request.event.display_settings.ticket_link }}" class="header-tab">
<i class="fa fa-ticket"></i> {% translate "Tickets" %}

{% with cfp=request.event.cfp %}
<a class="header-tab {% if not cfp.is_open and not access_code.is_valid %}disabled{% endif %}"
href="{{ request.event.urls.submit }}{{ submit_qs }}">
{% if cfp.is_open or access_code.is_valid %}
<i class="fa fa-bullhorn"></i> {% translate "Call for Speakers" %}
{% endif %}
</a>
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the CFP is closed or the access code is invalid, the link shows empty content because the icon and text are inside the conditional block. This creates an empty, disabled link in the navigation. Consider moving the entire <a> tag inside the conditional, or display the text outside the conditional with a disabled state message.

Suggested change
<a class="header-tab {% if not cfp.is_open and not access_code.is_valid %}disabled{% endif %}"
href="{{ request.event.urls.submit }}{{ submit_qs }}">
{% if cfp.is_open or access_code.is_valid %}
<i class="fa fa-bullhorn"></i> {% translate "Call for Speakers" %}
{% endif %}
</a>
{% if cfp.is_open or access_code.is_valid %}
<a class="header-tab {% if "/cfp/" in request.path_info %}active{% endif %}"
href="{{ request.event.urls.submit }}{{ submit_qs }}">
<i class="fa fa-bullhorn"></i> {% translate "Call for Speakers" %}
</a>
{% else %}
<a class="header-tab disabled" tabindex="-1" aria-disabled="true" href="#">
<i class="fa fa-bullhorn"></i> {% translate "Call for Speakers (Closed)" %}
</a>
{% endif %}

Copilot uses AI. Check for mistakes.
{% endif %}
{% endwith %}

<a id="join-event-link" href='{% url "agenda:event.onlinevideo.join" organizer=request.event.organizer.slug event=request.event.slug %}' class="header-tab">
<i class="fa fa-video-camera"></i> {% translate "Videos" %}
Expand Down
56 changes: 32 additions & 24 deletions app/eventyay/common/templates/common/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,20 +81,15 @@
{% endblocktranslate %}
</div>
{% endif %}
<div class="container{% block container_width %}{% endblock container_width %}" id="main-container">
<div class="container{% block container_width %}{% endblock container_width %}" id="main-container" style="margin-top: 3.8rem">
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inline styles should be moved to CSS files for better maintainability. The PR description mentions this as future work, but adding more inline styles increases technical debt. Consider defining this style in _layout.css.

Suggested change
<div class="container{% block container_width %}{% endblock container_width %}" id="main-container" style="margin-top: 3.8rem">
<div class="container{% block container_width %}{% endblock container_width %}" id="main-container">

Copilot uses AI. Check for mistakes.
<header>
<h1>
<a href="{% block nav_link %}{% endblock nav_link %}">
{% if request.event and request.event.logo %}
<img loading="lazy" src="{{ request.event.logo.url }}" id="event-logo" alt="{% translate "The event’s logo" %}">
{% elif request.event %}
{{ request.event.name }}
{% endif %}
</a>
</h1>
<div class="header-wrapper">
<div id="header-tabs">
{% block header_tabs %}{% endblock header_tabs %}
<h1 class="public-event-header">
<div class="event-logo">
<a href="{% block nav_link %}{% endblock nav_link %}">
{% if request.event and request.event.logo %}
<img loading="lazy" src="{{ request.event.logo.url }}" id="event-logo" alt="{% translate "The event’s logo" %}" style="border-radius: 10px;">
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inline styles should be moved to CSS files for better maintainability. The PR description mentions this as future work, but adding more inline styles increases technical debt. Consider defining this style in _layout.css.

Suggested change
<img loading="lazy" src="{{ request.event.logo.url }}" id="event-logo" alt="{% translate "The event’s logo" %}" style="border-radius: 10px;">
<img loading="lazy" src="{{ request.event.logo.url }}" id="event-logo" alt="{% translate "The event’s logo" %}" class="event-logo-img">

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline style should be moved to CSS file. The border-radius styling would be more maintainable in the external CSS, potentially as part of the #event-logo selector that already exists.

Suggested change
<img loading="lazy" src="{{ request.event.logo.url }}" id="event-logo" alt="{% translate "The event’s logo" %}" style="border-radius: 10px;">
<img loading="lazy" src="{{ request.event.logo.url }}" id="event-logo" alt="{% translate "The event’s logo" %}">

Copilot uses AI. Check for mistakes.
{% endif %}
</a>
</div>
<div class="header-row-right">
{% if request.event and request.event.locales|length > 1 and not is_html_export %}
Expand Down Expand Up @@ -134,30 +129,38 @@ <h1>
{{ request.user.get_display_name }} <i class="fa fa-caret-down ml-1"></i>
</summary>
<div id="user-dropdown" class="dropdown-content dropdown-content-s{% if rtl %}e{% else %}w{% endif %}">
<a href="{% url "cfp:event.user.submissions" organizer=request.event.organizer.slug event=request.event.slug %}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-sticky-note-o mr-2"></i>
<a href="{% url "eventyay_common:account.general"%}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-user mr-2 mb-1"></i>
{% translate "My Account" %}
</a>
<a href="{{ request.event.urls.user }}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-address-card-o mr-2 mb-1"></i>
{% translate "My Talk Profile" %}
</a>
<a href="{% url "eventyay_common:orders"%}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-shopping-cart mr-2 mb-1"></i>
{% translate "My Orders" %}
</a>
<a href="{% url "cfp:event.user.submissions" organizer=request.event.organizer.slug event=request.event.slug %}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-sticky-note-o mr-2 mb-1"></i>
{% translate "My proposals" %}
</a>
<a href="{{ request.event.urls.user_mails }}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-envelope mr-2"></i>
<i class="fa fa-envelope mr-2 mb-1"></i>
{% translate "My Emails" %}
</a>
<a href="{{ request.event.urls.user }}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-address-card-o mr-2"></i>
{% translate "My profile" %}
</a>
{% if can_see_orga_area %}
<hr>
<a href="{{ request.event.orga_urls.base }}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-gears mr-2"></i>
{% translate "Organiser area" %}
<a href="{% url 'eventyay_common:event.index' organizer=request.event.organizer.slug event=request.event.slug %}" class="dropdown-item" role="menuitem" tabindex="-1">
<i class="fa fa-gears mr-2 mb-1"></i>
{% translate "Organizer area" %}
</a>
{% endif %}
<hr>
<form action="{% url 'common:auth.logout' %}" method="post">
{% csrf_token %}
<button class="dropdown-item" role="menuitem" type="submit" tabindex="-1">
<i class="fa fa-sign-out mr-2 ml-1"></i>
<i class="fa fa-sign-out mr-2 mb-1 ml-1"></i>
{% translate "Logout" %}
</button>
</form>
Expand All @@ -171,6 +174,11 @@ <h1>
{% endif %}
{% endif %}
</div>
</h1>
<div class="header-wrapper">
<div id="header-tabs">
{% block header_tabs %}{% endblock header_tabs %}
</div>
</div>
</header>
<div class="card" id="main-card">
Expand Down
2 changes: 1 addition & 1 deletion app/eventyay/presale/templates/pretixpresale/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<img id="header-image" src="{{ MEDIA_PREFIX }}{{ event_logo }}" alt="{{ event.name }}" class="event-logo" />
{% endif %}
</div>
<header {% if event_logo %} class="custom-header" {% endif %}>
<header {% if event_logo %} class="custom-header" {% endif %} style="margin-top: -3.8rem;">
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inline styles should be moved to CSS files for better maintainability. The PR description mentions this as future work, but adding more inline styles increases technical debt. Consider defining this style in _layout.css.

Suggested change
<header {% if event_logo %} class="custom-header" {% endif %} style="margin-top: -3.8rem;">
<header {% if event_logo %} class="custom-header header-margin-top" {% endif %}>

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline style should be moved to CSS as mentioned in the PR description. The negative margin should be defined in the CSS file, either as part of the 'custom-header' class or through a modifier class.

Suggested change
<header {% if event_logo %} class="custom-header" {% endif %} style="margin-top: -3.8rem;">
<header{% if event_logo %} class="custom-header"{% endif %}>

Copilot uses AI. Check for mistakes.
{% block above %}
{% endblock %}
</header>
Expand Down
83 changes: 55 additions & 28 deletions app/eventyay/presale/templates/pretixpresale/event/fragment_nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,64 @@
{% load eventurl %}
{% load event_tags %}

<nav id="schedule-nav"{% if with_margin %} class="p-3"{% endif %}>
<div class="navigation">
<nav style="margin-top: 10px; margin-bottom: 3rem; overflow: scroll;">
<div class="navigation" style="font-size: 1.65rem; display: flex; gap: 2rem;">
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple inline styles should be moved to external CSS files as noted in the PR description. These styles (margin-top, margin-bottom, overflow, font-size, display, gap) would be more maintainable in a CSS class.

Copilot uses AI. Check for mistakes.
<a class="header-tab underline">
<i class="fa fa-ticket"></i> {% translate "Tickets" %}
</a>
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Tickets' link is missing an href attribute, making it non-functional. This appears to be the active/current page indicator, but it should still be a valid link or use a different element (like ) to avoid misleading screen readers and keyboard users.

Copilot uses AI. Check for mistakes.

{% if request.event|get_feature_flag:'show_schedule' %}
<div class="navigation-button">
<a href="{{ request.event.talk_schedule_url }}" class="header-nav btn btn-outline-success">
<i class="fa fa-calendar"></i> {% translate "Schedule" %}
</a>
</div>
<div class="navigation-button">
<a href="{{ request.event.talk_session_url }}" class="header-nav btn btn-outline-success">
<i class="fa fa-comments-o"></i> {% translate "Sessions" %}
</a>
</div>
<div class="navigation-button">
<a href="{{ request.event.talk_speaker_url }}" class="header-nav btn btn-outline-success">
<i class="fa fa-group"></i> {% translate "Speakers" %}
</a>
</div>
<a href="{{ request.event.talk_schedule_url }}" class="header-tab ">
<i class="fa fa-calendar"></i> {% translate "Schedule" %}
</a>

<a href="{{ request.event.talk_session_url }}" class="header-tab">
<i class="fa fa-comments-o"></i> {% translate "Sessions" %}
</a>

<a href="{{ request.event.talk_speaker_url }}" class="header-tab">
<i class="fa fa-group"></i> {% translate "Speakers" %}
</a>
{% endif %}
<div class="navigation-button">
<a target="_blank" class="header-nav btn btn-outline-success" data-toggle="popover">
<i class="fa fa-ticket"></i> {% translate "Tickets" %}

{% with cfp=request.event.cfp %}
<a class="header-tab {% if not cfp.is_open and not access_code.is_valid %}disabled{% endif %}"
href="{{ request.event.urls.submit }}{{ submit_qs }}">
{% if cfp.is_open or access_code.is_valid %}
<i class="fa fa-bullhorn"></i> {% translate "Call for Speakers" %}
{% endif %}
</a>
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the CFP is closed or the access code is invalid, the link shows empty content because the icon and text are inside the conditional block. This creates an empty, disabled link in the navigation. Consider moving the entire <a> tag inside the conditional, or display the text outside the conditional with a disabled state message.

Suggested change
<a class="header-tab {% if not cfp.is_open and not access_code.is_valid %}disabled{% endif %}"
href="{{ request.event.urls.submit }}{{ submit_qs }}">
{% if cfp.is_open or access_code.is_valid %}
<i class="fa fa-bullhorn"></i> {% translate "Call for Speakers" %}
{% endif %}
</a>
{% if cfp.is_open or access_code.is_valid %}
<a class="header-tab"
href="{{ request.event.urls.submit }}{{ submit_qs }}">
<i class="fa fa-bullhorn"></i> {% translate "Call for Speakers" %}
</a>
{% else %}
<span class="header-tab disabled" title="{% translate 'Call for Speakers is closed' %}">
<i class="fa fa-bullhorn"></i> {% translate "Call for Speakers" %}
</span>
{% endif %}

Copilot uses AI. Check for mistakes.
Copy link
Member

@hongquan hongquan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow this.

{% endwith %}

<div class="video-link">
<a join-event-link class="header-tab join-event {% if request.path_info == '/onlinevideo' %}underline{% endif %}"
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid HTML attribute 'join-event-link' without a value. This should either be removed, prefixed with 'data-' (e.g., 'data-join-event-link'), or given a value if it's meant to be an ID attribute (e.g., 'id="join-event-link"').

Suggested change
<a join-event-link class="header-tab join-event {% if request.path_info == '/onlinevideo' %}underline{% endif %}"
<a data-join-event-link class="header-tab join-event {% if request.path_info == '/onlinevideo' %}underline{% endif %}"

Copilot uses AI. Check for mistakes.
href='{% eventurl request.event "presale:event.onlinevideo.join" %}'>
<i class="fa fa-video-camera"></i> {% translate "Videos" %}
</a>
</div>
{% if is_video_plugin_enabled %}
<div class="video-link">
<a join-event-link class="header-nav btn btn-outline-success join-event"
href='{% eventurl request.event "presale:event.onlinevideo.join" %}'>
<i class="fa fa-video-camera"></i> {% translate "Join online event" %}
</a>
</div>
{% endif %}
</div>
</nav>

<style>
.navigation a {
cursor: pointer;
position: relative;
text-decoration: none;
padding-bottom: 4px;
}

.navigation a.underline::after {
content: '';
position: absolute;
bottom: 0;
left: -10px;
width: calc(100% + 20px);
height: 2px;
background-color: currentColor;
}

.navigation a:not(.underline):hover {
border-bottom: 2px dotted currentColor;
}

</style>
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inline styles embedded in <style> tags within templates should be moved to external CSS files for better maintainability, reusability, and caching. The PR description mentions this as future work, but consider creating a dedicated CSS file for navigation styles now to avoid increasing technical debt.

Copilot uses AI. Check for mistakes.
3 changes: 2 additions & 1 deletion app/eventyay/presale/templates/pretixpresale/fragment_login_status.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
{{ show_organizer_area|json_script:"show_organizer_area" }}
{{ 'popover-profile'|json_script:"popover_toggle" }}
{{ base_path|json_script:"base_path" }}
<nav class="login-hdr" aria-label='{% translate "account" %}'>
<nav class="login-hdr" aria-label="{% translate 'account' %}" style="{% if request.event and request.event.settings.event_logo_image %}margin-right: 18rem{% else %}margin-right: 0{% endif %}">
Copy link
Contributor

@sourcery-ai sourcery-ai bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Inline style for margin-right may cause layout issues on smaller screens.

Use responsive CSS classes or media queries to ensure margin-right adapts to various screen sizes for consistent header layout.

Suggested implementation:

<nav class="login-hdr{% if request.event and request.event.settings.event_logo_image %} login-hdr--with-logo{% endif %}" aria-label="{% translate 'account' %}">

You must add the following CSS to your main stylesheet (e.g., app/eventyay/presale/static/pretixpresale/css/style.css):

.login-hdr--with-logo {
    margin-right: 18rem;
}
@media (max-width: 768px) {
    .login-hdr--with-logo {
        margin-right: 0;
    }
}

This ensures the margin is only applied on larger screens and adapts responsively for smaller screens.

Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent quote usage in HTML attributes. The opening quote is a double quote (") while the closing quote is a single quote ('). Both should be double quotes for consistency: aria-label="{% translate 'account' %}".

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inline styles should be moved to CSS files for better maintainability. The PR description mentions moving inline CSS to .css files as a future task, but this adds more inline styles. Consider defining a CSS class in _layout.css instead.

Suggested change
<nav class="login-hdr" aria-label="{% translate 'account' %}" style="{% if request.event and request.event.settings.event_logo_image %}margin-right: 18rem{% else %}margin-right: 0{% endif %}">
<nav class="login-hdr{% if request.event and request.event.settings.event_logo_image %} login-hdr--with-logo{% endif %}" aria-label="{% translate 'account' %}">

Copilot uses AI. Check for mistakes.

{% if request.user.is_authenticated %}
<div class="navigation-button">
<a target="_blank" class="header-nav btn btn-outline-success" data-toggle="popover-profile">
Expand Down
16 changes: 13 additions & 3 deletions app/eventyay/static/cfp/css/_layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ header {
.header-wrapper {
width: 100%;
max-width: calc(100vw - 8px);
display: flex;
justify-content: space-between;
align-items: flex-end;
word-break: keep-all;
flex-wrap: nowrap;
}
Expand Down Expand Up @@ -76,6 +73,8 @@ header {
display: flex;
flex-wrap: nowrap;
flex-shrink: 0;
align-items: flex-end;
font-size: 1rem;

/* Inline locale links */
.locales-inline {
Expand Down Expand Up @@ -137,6 +136,11 @@ header {
}
}

.public-event-header {
display: flex;
margin-bottom: 14px
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon at the end of the CSS declaration. This should be margin-bottom: 14px; to follow CSS syntax standards.

Suggested change
margin-bottom: 14px
margin-bottom: 14px;

Copilot uses AI. Check for mistakes.
}

#main-card {
min-height: 300px;
box-shadow: 0 5px 10px rgb(0 0 0 / 0.2);
Expand Down Expand Up @@ -253,6 +257,12 @@ footer {
}
}

.header-wrapper {
overflow: scroll;
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overflow: scroll property will always show scrollbars even when content doesn't overflow. Consider using overflow: auto instead, which only shows scrollbars when necessary.

Suggested change
overflow: scroll;
overflow: auto;

Copilot uses AI. Check for mistakes.
Copy link
Member

@hongquan hongquan Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow this.

background: var(--color-bg);
padding-bottom: 6rem;
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The padding-bottom of 6rem inside a max-width: 576px media query seems excessively large and could cause significant whitespace issues on mobile devices. Consider reducing this value or verify if this is the intended behavior.

Suggested change
padding-bottom: 6rem;
padding-bottom: 2rem;

Copilot uses AI. Check for mistakes.
}

.user-row {
flex-direction: column;
}
Expand Down
21 changes: 18 additions & 3 deletions app/eventyay/static/pretixpresale/js/ui/popover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,22 +106,37 @@ $(function () {

const blocks = [
`<div data-name="popover-profile-menu">
<div class="profile-menu">
<a href="${basePath}${profilePath}" target="_self" class="btn btn-outline-success">
<i class="fa fa-user"></i> ${window.gettext('My Account')}
</a>
</div>
<div class="profile-menu">
<a href="${basePath}/${organizerName}/${eventSlug}/me" target="_self" class="btn btn-outline-success">
<i class="fa fa-address-card-o"></i> ${window.gettext('My Talk Profile')}
</a>
</div>
<div class="profile-menu">
<a href="${basePath}${orderPath}" target="_self" class="btn btn-outline-success">
<i class="fa fa-shopping-cart"></i> ${window.gettext('My Orders')}
</a>
</div>
<div class="profile-menu">
<a href="${basePath}${profilePath}" target="_self" class="btn btn-outline-success">
<i class="fa fa-user"></i> ${window.gettext('My Account')}
<a href="${basePath}/${organizerName}/${eventSlug}/me/submissions/" target="_self" class="btn btn-outline-success">
<i class="fa fa-sticky-note-o"></i> ${window.gettext('My Proposals')}
</a>
</div>
<div class="profile-menu">
<a href="${basePath}/${organizerName}/${eventSlug}/me/mails/" target="_self" class="btn btn-outline-success">
<i class="fa fa-envelope"></i> ${window.gettext('My Emails')}
</a>
</div>`,
];

if (showOrganizerArea) {
blocks.push(
`<div class="profile-menu organizer-area">
<a href="${basePath}/control/event/${organizerName}/${eventSlug}" target="_self" class="btn btn-outline-success">
<a href="${basePath}/common/event/${organizerName}/${eventSlug}" target="_self" class="btn btn-outline-success">
<i class="fa fa-users"></i> ${window.gettext('Organizer Area')}
</a>
</div>`
Expand Down
Loading