-
Notifications
You must be signed in to change notification settings - Fork 19
fix: Editor UI and Initial Image orientation #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR consolidates the editor’s UI by switching all transparent backgrounds to black for a consistent dark theme and removes the unused WhatsApp paint AppBar from the movable background image feature. Class diagram for removal of WhatsAppPaintAppBar from paint editorclassDiagram
class WhatsappPaintColorpicker
class ReactiveWidget
class WhatsAppPaintAppBar
class PaintEditor
PaintEditor : configs
PaintEditor : canUndo
PaintEditor : done()
PaintEditor : undoAction()
PaintEditor : close()
PaintEditor : activeColor
WhatsappPaintColorpicker <|-- ReactiveWidget
WhatsAppPaintAppBar <|-- ReactiveWidget
%% WhatsAppPaintAppBar is removed from _buildPaintEditorBody
%% Only WhatsappPaintColorpicker remains as child of ReactiveWidget in paint editor body
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Consider centralizing the repeated black background color into a shared constant or theme to avoid magic color values.
- Double-check that removing the WhatsAppPaintAppBar doesn’t inadvertently remove essential paint editor controls like undo/done.
- The PR title mentions initial image orientation, but I don’t see any orientation-handling changes here—please verify that the orientation fix has been included.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the repeated black background color into a shared constant or theme to avoid magic color values.
- Double-check that removing the WhatsAppPaintAppBar doesn’t inadvertently remove essential paint editor controls like undo/done.
- The PR title mentions initial image orientation, but I don’t see any orientation-handling changes here—please verify that the orientation fix has been included.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build StatusBuild successful. APKs to test: https://github.com/fossasia/magic-epaper-app/actions/runs/19008812792/artifacts/4440835974. Screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes unused code and updates background colors for consistency in the image editor. The changes clean up imports and UI elements that were no longer needed while standardizing the background color scheme to black.
- Removed unused
WhatsAppPaintAppBarimport and widget instantiation - Changed background colors from transparent to black in three locations for visual consistency
- Simplified the paint editor body by removing redundant UI components
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.







-1_display_selection.png?raw=true)
-2_sidebar.png?raw=true)
-3_ndef_screen.png?raw=true)
-4_filter_selection.png?raw=true)
-5_barcode_screen.png?raw=true)
-6_Barcode_added.png?raw=true)
-7_Templates_screen.png?raw=true)
Fixes: #270
Fixes: #241
Fixes #208
Summary by Sourcery
Update the movable background image editor UI by replacing transparent backgrounds with black and removing the deprecated WhatsApp paint app bar
Enhancements: