-
Notifications
You must be signed in to change notification settings - Fork 9.8k
feat: subcontracting workspace and sidebar #50388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: subcontracting workspace and sidebar #50388
Conversation
rohitwaghchaure
commented
Nov 6, 2025
75743be to
de35cd0
Compare
📝 WalkthroughWalkthroughAdds two new public JSON configuration files for a Subcontracting workspace UI:
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
de35cd0 to
bd74dbb
Compare
bd74dbb to
8ef1875
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
erpnext/subcontracting/workspace/subcontracting/subcontracting.json(1 hunks)erpnext/workspace_sidebar/subcontracting.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Python Unit Tests (4)
- GitHub Check: Python Unit Tests (3)
- GitHub Check: Python Unit Tests (1)
- GitHub Check: Python Unit Tests (2)
- GitHub Check: Patch Test
- GitHub Check: Summary
🔇 Additional comments (1)
erpnext/subcontracting/workspace/subcontracting/subcontracting.json (1)
5-5: Verify and update the creation timestamp.The creation timestamp is set to "2020-03-02 17:11:37.032604", which is significantly older than the current PR submission date (2025-11-06). This appears to be a copy-paste artifact from a template.
For new files added in this PR, the creation timestamp should reflect the actual creation date. Verify whether this is intentional or should be updated to match the modified date (2025-11-06 15:47:49.653794).