Skip to content

Conversation

@rohitwaghchaure
Copy link
Collaborator

image

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

📝 Walkthrough

Walkthrough

Adds two new public JSON configuration files for a Subcontracting workspace UI:

  • erpnext/subcontracting/workspace/subcontracting/subcontracting.json — a Workspace document that defines a Subcontracting workspace with a header, shortcuts (Sales Order, Subcontracting Inward Order, Subcontracting Delivery, Purchase Order, Subcontracting Order, Subcontracting Receipt, Subcontracting BOM), a spacer, and a Reports card. It includes metadata (app, doctype, name, module, label, icon, public flag, timestamps, owner) and link entries for three reports (Subcontract Order Summary, Subcontracted Item To Be Received, Subcontracted Raw Materials To Be Transferred).
  • erpnext/workspace_sidebar/subcontracting.json — a Workspace Sidebar document containing 16 items (Section Breaks and Links) arranged into sections labeled “Inward Order,” “Outward Order,” and “Reports,” linking to DocTypes and Reports such as Sales Order, Subcontracting Inward Order, Stock Entry, Subcontracting BOM, Subcontract Order Summary, and related reports. The file includes associated metadata for each item and the sidebar document.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify referenced DocTypes and Reports exist and their link_to values match actual names.
  • Confirm report entries have correct is_query_report flags where required.
  • Validate the JSON-encoded content string in the workspace file is well-formed and displays as intended.
  • Check sidebar items' parent, parenttype, and parentfield values for consistency with sidebar schema.
  • Ensure icon names and public/role fields align with UI conventions.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive The description contains only an embedded image with no textual explanation of the changes, making it impossible to assess relevance to the changeset. Add a written description explaining what the subcontracting workspace and sidebar do, what problems they solve, or key implementation details.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main changes: adding a subcontracting workspace and sidebar configuration files.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohitwaghchaure rohitwaghchaure force-pushed the feat-subcontracting-workspace branch from de35cd0 to bd74dbb Compare November 6, 2025 10:17
@rohitwaghchaure rohitwaghchaure force-pushed the feat-subcontracting-workspace branch from bd74dbb to 8ef1875 Compare November 6, 2025 10:18
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70483cf and 8ef1875.

📒 Files selected for processing (2)
  • erpnext/subcontracting/workspace/subcontracting/subcontracting.json (1 hunks)
  • erpnext/workspace_sidebar/subcontracting.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Python Unit Tests (4)
  • GitHub Check: Python Unit Tests (3)
  • GitHub Check: Python Unit Tests (1)
  • GitHub Check: Python Unit Tests (2)
  • GitHub Check: Patch Test
  • GitHub Check: Summary
🔇 Additional comments (1)
erpnext/subcontracting/workspace/subcontracting/subcontracting.json (1)

5-5: Verify and update the creation timestamp.

The creation timestamp is set to "2020-03-02 17:11:37.032604", which is significantly older than the current PR submission date (2025-11-06). This appears to be a copy-paste artifact from a template.

For new files added in this PR, the creation timestamp should reflect the actual creation date. Verify whether this is intentional or should be updated to match the modified date (2025-11-06 15:47:49.653794).

@rohitwaghchaure rohitwaghchaure merged commit b5df39f into frappe:develop Nov 17, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant