fix: re-export all sidebars #50732
fix: re-export all sidebars #50732
Conversation
📝 WalkthroughWalkthroughThis PR systematically removes metadata fields (creation, docstatus, doctype, idx, modified, modified_by, name, owner, parent, parentfield, parenttype) from workspace sidebar items across 20 JSON configuration files in the Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
erpnext/workspace_sidebar/projects.json (1)
80-85: Add missing "module" field to projects.json.The file is missing the "module" field that all other workspace sidebar files contain. Based on the pattern across 18 similar files, add
"module": "Projects"to the top-level metadata (typically between "idx" and "items" fields, or before "modified").
📜 Review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (22)
erpnext/workspace_sidebar/accounting.json(1 hunks)erpnext/workspace_sidebar/assets.json(1 hunks)erpnext/workspace_sidebar/banking.json(1 hunks)erpnext/workspace_sidebar/budget.json(1 hunks)erpnext/workspace_sidebar/buying.json(1 hunks)erpnext/workspace_sidebar/crm.json(1 hunks)erpnext/workspace_sidebar/financial_reports.json(1 hunks)erpnext/workspace_sidebar/home.json(1 hunks)erpnext/workspace_sidebar/manufacturing.json(1 hunks)erpnext/workspace_sidebar/opening_&_closing.json(1 hunks)erpnext/workspace_sidebar/payables.json(1 hunks)erpnext/workspace_sidebar/projects.json(1 hunks)erpnext/workspace_sidebar/quality.json(1 hunks)erpnext/workspace_sidebar/receivables.json(1 hunks)erpnext/workspace_sidebar/selling.json(1 hunks)erpnext/workspace_sidebar/settings.json(1 hunks)erpnext/workspace_sidebar/share_management.json(1 hunks)erpnext/workspace_sidebar/stock.json(1 hunks)erpnext/workspace_sidebar/subcontracting.json(1 hunks)erpnext/workspace_sidebar/subscription.json(1 hunks)erpnext/workspace_sidebar/support.json(1 hunks)erpnext/workspace_sidebar/taxes.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Python Unit Tests (4)
- GitHub Check: Python Unit Tests (2)
- GitHub Check: Python Unit Tests (3)
- GitHub Check: Python Unit Tests (1)
- GitHub Check: Patch Test
- GitHub Check: Summary
🔇 Additional comments (24)
erpnext/workspace_sidebar/taxes.json (1)
94-94: Timestamp updated as part of sidebar re-export.The modified timestamp reflects the re-export operation across all workspace sidebars. Verify that this bulk re-export was intentional and triggered by a known system change.
erpnext/workspace_sidebar/share_management.json (2)
17-17: Verify the intent of addingshow_arrow: 0to Share Management items.The
show_arrowfield is explicitly added to all Share Management sidebar items with value0. Confirm whether:
- This is a schema requirement/compatibility fix for this module
- Other workspace sidebar files should also have this field (visible in diff or not)
- The value
0correctly represents the intended display behaviorAlso applies to: 28-28, 39-39, 50-50
54-54: Timestamp updated as part of sidebar re-export.The modified timestamp reflects the re-export operation. Verify that this bulk re-export was intentional and triggered by a known system change.
erpnext/workspace_sidebar/buying.json (1)
250-250: Timestamp updated as part of sidebar re-export.The modified timestamp reflects the re-export operation. No structural changes to the Buying workspace sidebar are visible.
erpnext/workspace_sidebar/selling.json (1)
504-504: Timestamp updated as part of sidebar re-export.The modified timestamp reflects the re-export operation. The Selling workspace sidebar structure remains intact.
erpnext/workspace_sidebar/assets.json (2)
258-258: Timestamp updated as part of sidebar re-export.The modified timestamp reflects the re-export operation.
250-256: Verify the purpose of theurlfield on the Settings item.The Settings item includes an empty
"url": ""field that is not present in other sidebar items across the files. Confirm whether this is:
- A legacy field that should be removed
- An intentional field for URL-based navigation override
- An artifact from the sidebar regeneration process
erpnext/workspace_sidebar/manufacturing.json (1)
428-428: Timestamp updated as part of sidebar re-export.The modified timestamp reflects the re-export operation. Manufacturing sidebar structure is preserved.
erpnext/workspace_sidebar/banking.json (1)
115-115: Timestamp updated as part of sidebar re-export.The modified timestamp reflects the re-export operation. Banking sidebar structure is properly maintained.
erpnext/workspace_sidebar/subcontracting.json (1)
198-198: Timestamp updated as part of sidebar re-export.The modified timestamp reflects the re-export operation. Subcontracting sidebar structure is preserved.
erpnext/workspace_sidebar/budget.json (1)
82-82: Timestamp refresh for sidebar re-export looks good.The updated modification timestamp aligns with the systematic refresh across all sidebar files. However, verify that removal of per-item metadata fields (creation, docstatus, doctype, idx, modified, modified_by, name, owner, parent, parentfield, parenttype) won't impact sidebar rendering or any internal system operations that depend on these fields.
erpnext/workspace_sidebar/stock.json (1)
263-263: Sidebar structure and section hierarchy preserved correctly.All section breaks and child items maintain proper hierarchy (child flag correctly set). Verify that metadata field removals don't affect section rendering or parent-child relationships in the sidebar UI.
erpnext/workspace_sidebar/subscription.json (1)
46-46: Timestamp updated consistently.Structure and fields are correct. The metadata cleanup is consistent with other files.
erpnext/workspace_sidebar/opening_&_closing.json (1)
70-70: Timestamp refresh applied correctly.Sidebar structure is well-formed. No issues identified.
erpnext/workspace_sidebar/support.json (1)
181-181: Multi-section sidebar structure is well-preserved.Section breaks and child items maintain proper hierarchy. All navigation fields are retained correctly.
erpnext/workspace_sidebar/accounting.json (1)
390-390: Comprehensive sidebar structure is correct and consistent.Multi-section accounting sidebar maintains proper hierarchy and all navigation fields. Timestamp updated correctly.
erpnext/workspace_sidebar/financial_reports.json (1)
263-263: Financial reports sidebar structure is well-organized and complete.Multi-section hierarchy is properly maintained. All navigation and display fields are correctly preserved across all 21 items.
erpnext/workspace_sidebar/quality.json (1)
225-225: Timestamp-only change; no structural impact.The modified timestamp reflects a re-export refresh. All sidebar items retain their display and navigation properties.
erpnext/workspace_sidebar/settings.json (1)
142-142: Timestamp-only change; no structural impact.The modified timestamp reflects a re-export refresh. All sidebar items retain their display and navigation properties.
erpnext/workspace_sidebar/receivables.json (1)
93-93: Timestamp-only change; no structural impact.The modified timestamp reflects a re-export refresh. All sidebar items retain their display and navigation properties.
erpnext/workspace_sidebar/home.json (2)
14-30: Verify the intent of the first two item reordering in the Home sidebar.The first two sidebar items have been reordered:
- Item 1 is now "Item" (DocType) instead of "Home"
- Item 2 is now "Home" (Workspace)
This changes the navigation flow and user experience. The PR description does not explain the rationale for this reordering. Please confirm that this change is intentional and aligns with the intended sidebar hierarchy.
65-65: Timestamp-only change (if reordering is approved).Assuming the item reordering is intentional, the modified timestamp reflects a re-export refresh.
erpnext/workspace_sidebar/payables.json (1)
82-82: Timestamp-only change; no structural impact.The modified timestamp reflects a re-export refresh. All sidebar items retain their display and navigation properties.
erpnext/workspace_sidebar/crm.json (1)
500-500: Timestamp-only change; no structural impact.The modified timestamp reflects a re-export refresh. All sidebar items retain their display and navigation properties across all sections (Home, Dashboard, Reports, Maintenance, Sales Pipeline, Campaign, Setup, Settings).
1 participant
Re-exporting all sidebars
Depends on frappe/frappe#34875