feat(#210): remove hardcoded hci0 bluetooth adapter - #501
Merged
cachebag merged 1 commit intoJul 27, 2026
Merged
Conversation
cachebag
changed the title
cachebag
added
feature
cachebag
requested changes
Jul 16, 2026
cachebag
left a comment
cachebag
left a comment
Member
There was a problem hiding this comment.
Thanks for your help on this! I think you are on the right track actually. Let me know if you have further questions, I am happy to answer them.
Member
|
Ping? @morehwachege |
Contributor
Author
|
@cachebag thanks for the prompt review... Will definitely make the updates and update this pr for a secondary as soon as possible. |
Member
|
@morehwachege Take your time :] just checking in |
morehwachege
had a problem deploying
to
self-hosted-pr-integration
July 20, 2026 16:08 — with 
GitHub Actions
Failure
GitHub Actions
Failure
morehwachege
had a problem deploying
to
self-hosted-pr-integration
July 20, 2026 19:37 — with
GitHub Actions
Failure
GitHub Actions
Failure
morehwachege
requested a deployment
to
self-hosted-pr-integration
July 25, 2026 03:02 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
morehwachege
requested a deployment
to
self-hosted-pr-integration
July 25, 2026 03:19 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
morehwachege
requested a deployment
to
self-hosted-pr-integration
July 25, 2026 03:21 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
morehwachege
requested a deployment
to
self-hosted-pr-integration
July 25, 2026 03:45 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
morehwachege
requested a deployment
to
self-hosted-pr-integration
July 25, 2026 22:01 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
morehwachege
requested a deployment
to
self-hosted-pr-integration
July 25, 2026 22:02 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Co-authored-by: Antony <antony123muriithi@gmail.com>
cachebag
force-pushed
the
feat/dynamically-fetch-adapter
branch
from
July 27, 2026 13:07
08f7dac to
d6cfe3d
Compare
cachebag
temporarily deployed
to
self-hosted-pr-integration
July 27, 2026 13:07 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
cachebag
approved these changes
Jul 27, 2026
cachebag
left a comment
cachebag
left a comment
Member
There was a problem hiding this comment.
Thanks for getting this started and working through the feedback.
Since I am planning to cut a release soon, I’ve went ahead and took over. Let me know if you have any questions on anything!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #210
This issue was my starting point. Identifying the issue as hardcoded hci0 rather than finding the adapter in use on the device. My proposed fix on this PR was to query DBus for the adapter. It could be better or made reusable.
I've not tagged #481 to be closed since I don't completely understand
add_and_activate_connection. The changes on this PR do affectcore/custom_connection.rsin relation to the asycbluez_device_pathfnrequesting feedback
I'm open to suggestions if there's a more idiomatic or reusable way to discover the active Bluetooth adapter, or if there is a preferred approach within the project for solving this issue.