fix(#478): make EAP cert sources mutually exclusive - #521
Open
VrtxOmega wants to merge 2 commits into
Open
Conversation
VrtxOmega
temporarily deployed
to
self-hosted-pr-integration
July 30, 2026 01:19 — with
GitHub Actions
Inactive
cachebag
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #478.
Summary
EapCertSource::PathorEapCertSource::Blobvalue, making conflicting sources unrepresentablebuild_wifi_connection,wpa_eap, andwpa3_eap_192_bitinfallible and preserve fluent builder chainingOpen and WPA-PSK builder behavior is unchanged. The requested
EapOptionsfield redesign is a breaking public-API change and is recorded in the changelog.Validation
cargo fmt --all -- --checkcargo checkcargo clippy --all-targets --all-features -- -D warningscargo test -p nmrs --lib --all-features— 627 passedcargo test --doc --all-features --workspace— 129 passed, 16 ignoredcargo test --all-features --workspace— 627 unit tests passed; 4 isolated-environment integration tests ignored as designedgit diff --check origin/master...HEADcargo semver-checks check-release -p nmrs— expected failure at the current3.4.2version because the enum redesign removes six public fields; the repository release policy classifies this as a major-version changeThe source and behavior gates pass. The remaining release-policy choice is whether this redesign should target the next major release or use a compatibility migration; I have not added an unrequested version bump.
AI assistance
I used Codex to inspect the issue and maintainer review, implement the focused typed-source redesign and regression tests, and run the verification commands above. I reviewed the exact diff and verification output before updating this pull request.