feat(feed): save feed state before going to common friend#244
feat(feed): save feed state before going to common friend#244kabaniery wants to merge 4 commits into
Conversation
# Conflicts: # src/app/feed-dialog.tsx # src/app/feed-review-deck.tsx
|
@bakatrouble We have this tutorial https://github.com/friendly-social/web/blob/dev/docs/WORKFLOW.md We try to keep 1 commit per PR if possible. So can you rebase and submit changes as a single commit? |
|
@y9san9 fixed merge conflict and prettier errors |
| ); | ||
|
|
||
| useEffect(() => { | ||
| const feedState = initialFeedState.current; |
There was a problem hiding this comment.
Seems like the feed state is not reset properly, which causes a closed feed dialog to be opened again on page refresh:
| }, | ||
| }, | ||
| replace: true, | ||
| }); |
There was a problem hiding this comment.
I would propose implementing this logic with URL search parameters (https://reactrouter.com/api/hooks/useSearchParams). Then we wouldn't have to use this 'fake' navigate call to save the state
| }; | ||
| } | ||
|
|
||
| export type EmailBindingSuggestionStatus = |
|
Convert to draft means that we are waiting for changes, once you think this is ready for review, make it ready for review again |
3 participants
#183