Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
補講（MakeupClass）の教室情報が「科目ID+曜日+時限」で検索されヒットしないケースがあったため、科目IDのみで通常時間割から教室を引くようにして補講カレンダーの教室表示を改善するPRです。
Changes:
- 時間割から「科目ID → 教室」の対応マップを構築し、補講の教室決定に利用
- 補講の教室はDBに無い前提を明確化するコメントを追加（通常時間割の教室で代替）
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kantacky
approved these changes
Apr 6, 2026
Member
kantacky
left a comment
kantacky
left a comment
There was a problem hiding this comment.
Admin の dev で動作確認しました
大丈夫そうです
masaya-osuga
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やったこと
補講の科目ID，曜日，時限で教室を検索していたのでヒットしなかった
科目IDのみで検索するように変更
複数ある場合（週2回ある授業とか）は最初にヒットした教室で対応．これはあまり良くないと思うけど一旦
確認したこと
メモ