segmentation_shape metadata reformat - #260
Open
TeunHuijben wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 93.78% 93.78% -0.01%
==========================================
Files 59 59
Lines 3285 3282 -3
==========================================
- Hits 3081 3078 -3
Misses 204 204 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TeunHuijben
force-pushed
the
fix-segmentation-shape
branch
from
July 27, 2026 19:37
204388f to
c0af650
Compare
Contributor
|
Can we add an API in tracksdata for saving and loading segmentation metadata (shape and voxel size?). Then, we don't need to depend on internal tracksdata implementation details, and tracksdata can change where this info is stored at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connected to: funkelab/motile_tracker#459
Problem:
.extra.tracksdata.shapesegmentation_shapeat the top level (outside the geff metadata)Solution:
This PR removes the
segmentation_shapelogic, and fully uses the existing tracksdata format of saving the shape inmetadata.extra.tracksdata.shape. When reading the shape from the metadata we do a double check for backwards compatibility.For geffs that are exported from motile_tracker and then imported, it doesn't matter where we save the shape, because that is an internal discussion. But for geffs exported by other tracksdata-based tracking tools (ultrack, hoct, etc.), we are now natively compatible.
I will implement the accompanying changes in motile_tracker in a separate PR there