fix: add reconnect support to JsWidget so deephaven.ui widgets revive - #4
Open
fyrkov wants to merge 10 commits into
Open
fix: add reconnect support to JsWidget so deephaven.ui widgets revive#4fyrkov wants to merge 10 commits into
fyrkov wants to merge 10 commits into
Conversation
Release notes: https://github.com/deephaven/web-client-ui/releases/tag/v1.26.0 - DH-22030: Add event handler prereqs to chart Release notes: https://github.com/deephaven/web-client-ui/releases/tag/v1.25.0 Features - DH-21344: Dropdown for input table enums Bug Fixes - DH-22961: Content toolbar buttons overflow - DH-23020: Fix input table delete exceeds max stack - DH-23038: Fix extraneous characters from input table context menu paste
…aven#8246) Corrects sorted-column metadata assignment during `SourceTable` coalescing. **Changes:** - Applies sorting metadata to the coalesced result instead of the published source table. - Updates round-trip tests and adds regression coverage.
I let Claude write a lot of method descriptions. If it seems like that is wasting more time on editing than it saves on writing, I will not do that on the next PR.
BREAKING CHANGE: SQL window functions (including FIRST_VALUE and LAST_VALUE) are no longer supported. This is due to stricter validation that makes the OVER clause mandatory for these functions; because our current SQL engine does not support evaluating the OVER clause, all window functions have been disabled.
fyrkov
force-pushed
the
jswidget-reconnect-support
branch
from
July 17, 2026 18:34
8d2a823 to
9d1178e
Compare
- JsWidget.die() now unregisters from simpleReconnectableInstances (mirroring close()), so a widget whose revive fails stops receiving disconnect/refetch callbacks on every future reconnect. - getWidget(JsVariableDefinition) delegates to getWidget(TypedTicket) instead of duplicating its construction body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsWidget extended HasEventHandling and was never registered as reconnectable, so after a disconnect its message stream was nulled and never reopened - every subsequent message became a silent no-op, leaving deephaven.ui components (e.g. a ui.button) dead until page reload.
Make JsWidget lifecycle-aware (extend HasLifecycle) and register plain widgets as reconnectable, so on reconnect it reopens its stream, emits disconnect/ reconnect events, and re-delivers the current document.
Requires the companion client change deephaven/deephaven-plugins#1390 to fully restore interactivity; manual verification on 42.0+ also needs the transport reconnect fix (deephaven#8235).