Repository navigation
Put orthogonal subfield groups in standard form - #184
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 18 18
Lines 8680 8680
=======================================
Hits 8541 8541
Misses 139 139
🚀 New features to boost your workflow:
|
fingolfin
marked this pull request as draft
November 13, 2026 07:15
SubfieldOmega returned Omega(epsilon_0, d, q0) or SO(epsilon_0, d, q0) in GAP's standard form over GF(q0). For epsilon_0 = -1 that form is not GAP's standard form over GF(q), so the C5 subgroups of Omega+(d, q) for square q, and of Omega-(d, q) for q = q0^r with r an odd prime, had generators outside Omega(epsilon, d, q). Conjugate them to the standard form over GF(q). Assisted-by: Generative AI
fingolfin
force-pushed
the
mh-ai/omega-subfield-standard-form
branch
from
November 14, 2026 22:09
9f37229 to
3e75ad6
Compare
fingolfin
marked this pull request as ready for review
November 14, 2026 22:12
fingolfin
enabled stacked auto-merge (squash)
November 14, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubfieldOmega returned Omega(epsilon_0, d, q0) or SO(epsilon_0, d, q0) in GAP's standard form over GF(q0). For epsilon_0 = -1 that form is not GAP's standard form over GF(q), so the C5 subgroups of Omega+(d, q) for square q, and of Omega-(d, q) for q = q0^r with r an odd prime, had generators outside Omega(epsilon, d, q). Conjugate them to the standard form over GF(q).
Assisted-by: Generative AI