Skip to content

Put orthogonal subfield groups in standard form - #184

Merged
fingolfin merged 1 commit into
mainfrom
mh-ai/omega-subfield-standard-form
Nov 16, 2026
Merged

fingolfin merged 1 commit into
mainfrom
mh-ai/omega-subfield-standard-form

Conversation

@fingolfin

Copy link
Copy Markdown
Member

SubfieldOmega returned Omega(epsilon_0, d, q0) or SO(epsilon_0, d, q0) in GAP's standard form over GF(q0). For epsilon_0 = -1 that form is not GAP's standard form over GF(q), so the C5 subgroups of Omega+(d, q) for square q, and of Omega-(d, q) for q = q0^r with r an odd prime, had generators outside Omega(epsilon, d, q). Conjugate them to the standard form over GF(q).

Assisted-by: Generative AI

@fingolfin
fingolfin added this pull request to stack #185 November 13, 2026 00:26
@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.39%. Comparing base (7d1d300) to head (3e75ad6).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          18       18           
  Lines        8680     8680           
=======================================
  Hits         8541     8541           
  Misses        139      139           
Files with missing lines Coverage Δ
gap/SubfieldMatrixGroups.gi 98.46% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin marked this pull request as draft November 13, 2026 07:15
Base automatically changed from mh-ai/su-parabolics-even-q to main November 14, 2026 22:09
SubfieldOmega returned Omega(epsilon_0, d, q0) or SO(epsilon_0, d, q0)
in GAP's standard form over GF(q0). For epsilon_0 = -1 that form is
not GAP's standard form over GF(q), so the C5 subgroups of
Omega+(d, q) for square q, and of Omega-(d, q) for q = q0^r with r an
odd prime, had generators outside Omega(epsilon, d, q). Conjugate them
to the standard form over GF(q).

Assisted-by: Generative AI
@fingolfin
fingolfin force-pushed the mh-ai/omega-subfield-standard-form branch from 9f37229 to 3e75ad6 Compare November 14, 2026 22:09
@fingolfin
fingolfin marked this pull request as ready for review November 14, 2026 22:12
@fingolfin
fingolfin enabled stacked auto-merge (squash) November 14, 2026 22:13
@fingolfin
fingolfin merged commit b6892ae into main Nov 16, 2026
7 of 8 checks passed
@fingolfin
fingolfin deleted the mh-ai/omega-subfield-standard-form branch November 16, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant