Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 98.39% 98.40%
=======================================
Files 18 18
Lines 8680 8691 +11
=======================================
+ Hits 8541 8552 +11
Misses 139 139
🚀 New features to boost your workflow:
|
fingolfin
marked this pull request as draft
November 13, 2026 07:15
NormGOMinusGO returned an element of the conformal group of StandardOrthogonalForm, which for epsilon = -1 differs from the form preserved by GAP's GO(-1, n, q). The C9 subgroups of Omega-(n, q) conjugated by it had generators outside Omega-(n, q), for example for (n, q) = (6, 11) and (8, 25). Conjugate the element to GAP's form. Assisted-by: Generative AI
C9SubgroupsOrthogonalGroupGeneric conjugates its groups by elements normalising Omega, but G ^ x carries the invariant forms over only from GAP 4.16 on. On GAP 4.15 the conjugates had no forms, and InvariantBilinearForm failed on them, for example for the C9 subgroups of Omega-(6, 11). Set the forms of G on each conjugate. The conjugating elements are isometries or similarities of these forms, so the conjugates preserve them. Assisted-by: Generative AI
fingolfin
force-pushed
the
mh-ai/normgominusgo-form
branch
from
November 15, 2026 00:11
4136b0a to
14fafe8
Compare
fingolfin
marked this pull request as ready for review
November 17, 2026 00:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NormGOMinusGO returned an element of the conformal group of StandardOrthogonalForm, which for epsilon = -1 differs from the form preserved by GAP's GO(-1, n, q). The C9 subgroups of Omega-(n, q) conjugated by it had generators outside Omega-(n, q), for example for (n, q) = (6, 11) and (8, 25). Conjugate the element to GAP's form.
Assisted-by: Generative AI