Skip to content

Make NormGOMinusGO a similarity of GAP's form - #189

Open
fingolfin wants to merge 2 commits into
mainfrom
mh-ai/normgominusgo-form
Open

fingolfin wants to merge 2 commits into
mainfrom
mh-ai/normgominusgo-form

Conversation

@fingolfin

Copy link
Copy Markdown
Member

NormGOMinusGO returned an element of the conformal group of StandardOrthogonalForm, which for epsilon = -1 differs from the form preserved by GAP's GO(-1, n, q). The C9 subgroups of Omega-(n, q) conjugated by it had generators outside Omega-(n, q), for example for (n, q) = (6, 11) and (8, 25). Conjugate the element to GAP's form.

Assisted-by: Generative AI

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.40%. Comparing base (5a90919) to head (14fafe8).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   98.39%   98.40%           
=======================================
  Files          18       18           
  Lines        8680     8691   +11     
=======================================
+ Hits         8541     8552   +11     
  Misses        139      139           
Files with missing lines Coverage Δ
gap/ClassicalMaximals.gi 99.84% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin marked this pull request as draft November 13, 2026 07:15
Base automatically changed from mh-ai/su-parabolics-even-q to main November 14, 2026 22:09
NormGOMinusGO returned an element of the conformal group of
StandardOrthogonalForm, which for epsilon = -1 differs from the form
preserved by GAP's GO(-1, n, q). The C9 subgroups of Omega-(n, q)
conjugated by it had generators outside Omega-(n, q), for example for
(n, q) = (6, 11) and (8, 25). Conjugate the element to GAP's form.

Assisted-by: Generative AI
C9SubgroupsOrthogonalGroupGeneric conjugates its groups by elements
normalising Omega, but G ^ x carries the invariant forms over only from
GAP 4.16 on. On GAP 4.15 the conjugates had no forms, and
InvariantBilinearForm failed on them, for example for the C9 subgroups
of Omega-(6, 11).

Set the forms of G on each conjugate. The conjugating elements are
isometries or similarities of these forms, so the conjugates preserve
them.

Assisted-by: Generative AI
@fingolfin
fingolfin force-pushed the mh-ai/normgominusgo-form branch from 4136b0a to 14fafe8 Compare November 15, 2026 00:11
@fingolfin
fingolfin marked this pull request as ready for review November 17, 2026 00:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant