Repository navigation
Conversation
Member
Author
|
This is fairly big so I'll try to split it up into several PRs that are easier to review (by focusing on one kind of change each) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 98.39% 98.45% +0.05%
==========================================
Files 18 18
Lines 8680 8680
==========================================
+ Hits 8541 8546 +5
+ Misses 139 134 -5
🚀 New features to boost your workflow:
|
fingolfin
force-pushed
the
mh-ai/fix-typos-and-references
branch
from
November 15, 2026 00:35
724279f to
6483432
Compare
Member
Author
fingolfin
force-pushed
the
mh-ai/fix-typos-and-references
branch
from
November 15, 2026 09:21
6483432 to
625bd70
Compare
Check every citation of [BHR13], [KL90], [HR05], [HR10] and the other cited papers against the sources and fix those that point to the wrong item: tables of the wrong dimension, class or kind, propositions that are lemmas or theorems, a nonexistent Table 8.86, and a misnumbered page. Rename the bibliography key R-D13 to RD04 to match the year of the paper. Fix comments that contradict the code: wrong variable and function names, unbalanced or wrong formulas, a wrong field characteristic, and wrong descriptions of generators. In the manual, list the missing type "S" for ClassicalMaximalsGeneric and drop the flat-list mode from the MatrixByEntries documentation, which is not implemented. Make error messages name the actual arguments and state the condition the code checks, e.g. "at least 3" instead of "at least 2", and update the expected test output. Assisted-by: Generative AI
fingolfin
force-pushed
the
mh-ai/fix-typos-and-references
branch
from
November 16, 2026 00:01
625bd70 to
9912016
Compare
chseeger
approved these changes
Nov 16, 2026
Comment on lines
2515
to
2518
| # Cf. Propositions 3.2.5 (n = 3), 3.3.6 (n = 4), | ||
| # 3.4.3 (n = 5), 3.6.3 (n = 7), | ||
| # 3.7.9 (n = 8), 3.8.5 (n = 9), | ||
| # 3.10.3 (n = 11) in [BHR13] |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Cf. Propositions 3.2.5 (n = 3), 3.3.6 (n = 4), | |
| # 3.4.3 (n = 5), 3.6.3 (n = 7), | |
| # 3.7.9 (n = 8), 3.8.5 (n = 9), | |
| # 3.10.3 (n = 11) in [BHR13] | |
| # Cf. Propositions 3.2.5 (n = 3), 3.3.6 (n = 4), | |
| # 3.4.3 (n = 5), 3.6.3 (n = 7), | |
| # 3.7.9 (n = 8), 3.8.5 (n = 9), | |
| # 3.10.3 (n = 11) in [BHR13] |
| # the entry M[i, j] is omega ^ k (if M[i, j] = 0 then the corresponding block | ||
| # is zero as well). | ||
| # This is the function Theta(...) from [HR05] defined on page 61 before Lemma 6.2. | ||
| # This is the function Theta(...) from [HR05] defined on page 60 before Lemma 6.2. |
Collaborator
There was a problem hiding this comment.
At least in my copy of [HR05], this is indeed on page 61 (printed page number).
|
|
||
| # If type = "S" then find a beta in GF(q ^ 2) with beta + beta ^ q = alpha. | ||
| # If type = "P" then find a beta in GF(q ^ 2) with gamma * gamma ^ q = alpha. | ||
| # If type = "P" then find a beta in GF(q ^ 2) with beta * beta ^ q = alpha. |
Collaborator
There was a problem hiding this comment.
Suggested change
| # If type = "P" then find a beta in GF(q ^ 2) with beta * beta ^ q = alpha. | |
| # If type = "P" then find a gamma in GF(q ^ 2) with gamma * gamma ^ q = alpha. |
This matches the notation in [HR05].
Restore page 61 for Theta in [HR05], the printed page number, and use gamma, the notation of [HR05], for the type "P" solution of SolveFrobeniusEquation. Align the continuation lines of the SU C6 citations. Test the three error messages this branch reworded and no test reached. Assisted-by: Generative AI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct spelling and grammar in comments, the manual and the README, and fix comments that contradict the code, such as wrong variable names, unbalanced formulas and a wrong field characteristic.
Check every citation of [BHR13], [KL90], [HR05], [HR10] and the other cited papers against the sources and fix those that point to the wrong item: tables of the wrong dimension, class or kind, propositions that are lemmas or theorems, a nonexistent Table 8.86, and a misnumbered page. Rename the bibliography key R-D13 to RD04 to match the year of the paper.
In the manual, list the missing type "S" for ClassicalMaximalsGeneric and separate @arguments with commas, so signatures render as "GLMinusSL( n, q )" instead of "GLMinusSL( n q )". Drop the flat-list mode from the MatrixByEntries documentation, which is not implemented.
Make error messages name the actual arguments and state the condition the code checks, e.g. "at least 3" instead of "at least 2", and update the expected test output.
Assisted-by: Generative AI