Skip to content

Fix three latent bugs in subgroup constructions - #192

Merged
fingolfin merged 1 commit into
mainfrom
mh-ai/fix-latent-bugs
Nov 15, 2026
Merged

fingolfin merged 1 commit into
mainfrom
mh-ai/fix-latent-bugs

Conversation

@fingolfin

Copy link
Copy Markdown
Member

None of these changes the output today, so there is no failing test:

  • GammaLMeetOmega stored its quadratic form with baseDomain set to the GAP global field (the string "editor") instead of GF(q). ConjugateToStandardForm always replaces the form afterwards.

  • SUStabilizerOfNonDegenerateSubspace (k odd, d even) wrote column dHalf twice and never column dHalf + 1 in the last kHalf rows. The source entries are zero for every SU(k, q) generator GAP returns.

  • CM_O8qMapToCover computed formx * formi^(-1), i.e. formx * form, where formi = form^-1. The two agree because form^2 = 1, checked for q <= 11.

Assisted-by: Generative AI

None of these changes the output today, so there is no failing test:

- GammaLMeetOmega stored its quadratic form with baseDomain set to
  the GAP global `field` (the string "editor") instead of GF(q).
  ConjugateToStandardForm always replaces the form afterwards.

- SUStabilizerOfNonDegenerateSubspace (k odd, d even) wrote column
  dHalf twice and never column dHalf + 1 in the last kHalf rows. The
  source entries are zero for every SU(k, q) generator GAP returns.

- CM_O8qMapToCover computed `formx * formi^(-1)`, i.e. `formx * form`,
  where `formi = form^-1`. The two agree because form^2 = 1, checked
  for q <= 11.

Assisted-by: Generative AI
@codecov

codecov Bot commented Nov 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.39%. Comparing base (5a90919) to head (5012f23).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          18       18           
  Lines        8680     8680           
=======================================
  Hits         8541     8541           
  Misses        139      139           
Files with missing lines Coverage Δ
gap/AlmostSimpleDefiningCharacteristic.gi 98.94% <100.00%> (ø)
gap/ReducibleMatrixGroups.gi 98.76% <100.00%> (ø)
gap/SemilinearMatrixGroups.gi 92.27% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin merged commit 0c719d7 into main Nov 15, 2026
5 checks passed
@fingolfin
fingolfin deleted the mh-ai/fix-latent-bugs branch November 15, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant