Repository navigation
Fix three latent bugs in subgroup constructions - #192
Merged
Merged
Conversation
None of these changes the output today, so there is no failing test: - GammaLMeetOmega stored its quadratic form with baseDomain set to the GAP global `field` (the string "editor") instead of GF(q). ConjugateToStandardForm always replaces the form afterwards. - SUStabilizerOfNonDegenerateSubspace (k odd, d even) wrote column dHalf twice and never column dHalf + 1 in the last kHalf rows. The source entries are zero for every SU(k, q) generator GAP returns. - CM_O8qMapToCover computed `formx * formi^(-1)`, i.e. `formx * form`, where `formi = form^-1`. The two agree because form^2 = 1, checked for q <= 11. Assisted-by: Generative AI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 18 18
Lines 8680 8680
=======================================
Hits 8541 8541
Misses 139 139
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these changes the output today, so there is no failing test:
GammaLMeetOmega stored its quadratic form with baseDomain set to the GAP global
field(the string "editor") instead of GF(q). ConjugateToStandardForm always replaces the form afterwards.SUStabilizerOfNonDegenerateSubspace (k odd, d even) wrote column dHalf twice and never column dHalf + 1 in the last kHalf rows. The source entries are zero for every SU(k, q) generator GAP returns.
CM_O8qMapToCover computed
formx * formi^(-1), i.e.formx * form, whereformi = form^-1. The two agree because form^2 = 1, checked for q <= 11.Assisted-by: Generative AI