Repository navigation
Conversation
CheckPairwiseNonConjugateOmega now maps the groups with ImagesSet. TestOmegaClasses also covers Omega+(6, 2), Omega+(8, 2), Omega(5, 3) and Omega(7, 3), whose orders match the maximal subgroups stored in GAP's character table library. Omega-(6, 4), Omega-(8, 4) and Omega-(10, 2) have no stored maximal subgroups and get the pairwise check only; it fails for all three before 5a90919. Assisted-by: Generative AI
Compare the orders of the maximal subgroups with those stored in GAP's character table library, for the 53 groups whose maximal subgroups it stores. The check needs only the stored sizes; before 5a90919 it fails for Omega-(6, 3) and Omega-(8, 2). ctbllib becomes a test dependency. Assisted-by: Generative AI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 18 18
Lines 8680 8680
=======================================
Hits 8541 8541
Misses 139 139 🚀 New features to boost your workflow:
|
CheckMaximalOrders compares the orders with the character table library, so TestOmegaClasses keeps only the conjugacy and size checks and covers all eight groups alike. O-(8, 4) adds 5 s. Assisted-by: Generative AI
StandardClassicalGroup returns GAP's SL, SU, Sp or Omega for a type name of ClassicalMaximalsGeneric. It replaces four copies of that mapping in the tests. Assisted-by: Generative AI
StandardClassicalGroup now maps every type name to a constructor in one record. Omega(e, n, q) calls these three and only adds a name. Assisted-by: Generative AI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckPairwiseNonConjugateOmega now maps the groups with ImagesSet. TestOmegaClasses also covers Omega+(6, 2), Omega+(8, 2), Omega(5, 3) and Omega(7, 3), whose orders match the maximal subgroups stored in GAP's character table library. Omega-(6, 4), Omega-(8, 4) and Omega-(10, 2) have no stored maximal subgroups and get the pairwise check only; it fails for all three before 5a90919.
Assisted-by: Generative AI