Skip to content

Test the Omega classes in more cases - #195

Open
fingolfin wants to merge 5 commits into
mainfrom
mh-ai/omega-class-tests
Open

fingolfin wants to merge 5 commits into
mainfrom
mh-ai/omega-class-tests

Conversation

@fingolfin

Copy link
Copy Markdown
Member

CheckPairwiseNonConjugateOmega now maps the groups with ImagesSet. TestOmegaClasses also covers Omega+(6, 2), Omega+(8, 2), Omega(5, 3) and Omega(7, 3), whose orders match the maximal subgroups stored in GAP's character table library. Omega-(6, 4), Omega-(8, 4) and Omega-(10, 2) have no stored maximal subgroups and get the pairwise check only; it fails for all three before 5a90919.

Assisted-by: Generative AI

CheckPairwiseNonConjugateOmega now maps the groups with ImagesSet.
TestOmegaClasses also covers Omega+(6, 2), Omega+(8, 2), Omega(5, 3)
and Omega(7, 3), whose orders match the maximal subgroups stored in
GAP's character table library. Omega-(6, 4), Omega-(8, 4) and
Omega-(10, 2) have no stored maximal subgroups and get the pairwise
check only; it fails for all three before 5a90919.

Assisted-by: Generative AI
Compare the orders of the maximal subgroups with those stored in GAP's
character table library, for the 53 groups whose maximal subgroups it
stores. The check needs only the stored sizes; before 5a90919 it fails
for Omega-(6, 3) and Omega-(8, 2). ctbllib becomes a test dependency.

Assisted-by: Generative AI
@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.39%. Comparing base (5a90919) to head (3bfa9d2).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          18       18           
  Lines        8680     8680           
=======================================
  Hits         8541     8541           
  Misses        139      139           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CheckMaximalOrders compares the orders with the character table
library, so TestOmegaClasses keeps only the conjugacy and size checks
and covers all eight groups alike. O-(8, 4) adds 5 s.

Assisted-by: Generative AI
StandardClassicalGroup returns GAP's SL, SU, Sp or Omega for a type
name of ClassicalMaximalsGeneric. It replaces four copies of that
mapping in the tests.

Assisted-by: Generative AI
StandardClassicalGroup now maps every type name to a constructor in
one record. Omega(e, n, q) calls these three and only adds a name.

Assisted-by: Generative AI

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant