Skip to content

Copy the Forms helpers recog uses into RECOG - #561

Open
fingolfin wants to merge 1 commit into
masterfrom
mh-ai/copy-forms-helpers
Open

fingolfin wants to merge 1 commit into
masterfrom
mh-ai/copy-forms-helpers

Conversation

@fingolfin

Copy link
Copy Markdown
Member

recog called four undocumented ClassicalForms_* functions of the Forms package, which Forms keeps only for recog. Copy them and the seven helpers they call into gap/matrix/classicalforms.gi as RECOG.* functions, so Forms can drop the four. DualFrobeniusGModule is not copied: GAP's SMTX.TwistedDualModule computes the same module.

InfoForms becomes InfoRecog_ClassicalNaming at level 2, an unconditional Print in QuadraticForm2 becomes an Info message, and unused locals are dropped.

Fixes #7.

Assisted-by: Generative AI

recog called four undocumented ClassicalForms_* functions of the Forms
package, which Forms keeps only for recog. Copy them and the seven
helpers they call into gap/matrix/classicalforms.gi as RECOG.*
functions, so Forms can drop the four. DualFrobeniusGModule is not
copied: GAP's SMTX.TwistedDualModule computes the same module.

Results are unchanged since Forms 1.2.11, recog's minimum. InfoForms
becomes InfoRecog_ClassicalNaming at level 2, an unconditional Print
in QuadraticForm2 becomes an Info message, and unused locals are
dropped.

Fixes #7.

Assisted-by: Generative AI
@fingolfin
fingolfin added this pull request to stack #563 November 15, 2026 22:13
@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.78378% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.60%. Comparing base (6b55721) to head (f0dcb34).

Files with missing lines Patch % Lines
gap/matrix/classicalforms.gi 93.71% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   86.46%   86.60%   +0.13%     
==========================================
  Files          49       50       +1     
  Lines       19382    19748     +366     
==========================================
+ Hits        16759    17102     +343     
- Misses       2623     2646      +23     
Files with missing lines Coverage Δ
gap/matrix/classical.gi 85.17% <100.00%> (ø)
gap/matrix/classicalforms.gi 93.71% <93.71%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

recog uses undocumented "forms" methods

1 participant