Repository navigation
Conversation
recog called four undocumented ClassicalForms_* functions of the Forms package, which Forms keeps only for recog. Copy them and the seven helpers they call into gap/matrix/classicalforms.gi as RECOG.* functions, so Forms can drop the four. DualFrobeniusGModule is not copied: GAP's SMTX.TwistedDualModule computes the same module. Results are unchanged since Forms 1.2.11, recog's minimum. InfoForms becomes InfoRecog_ClassicalNaming at level 2, an unconditional Print in QuadraticForm2 becomes an Info message, and unused locals are dropped. Fixes #7. Assisted-by: Generative AI
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 86.46% 86.60% +0.13%
==========================================
Files 49 50 +1
Lines 19382 19748 +366
==========================================
+ Hits 16759 17102 +343
- Misses 2623 2646 +23
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recog called four undocumented
ClassicalForms_*functions of the Forms package, which Forms keeps only for recog. Copy them and the seven helpers they call intogap/matrix/classicalforms.giasRECOG.* functions, so Forms can drop the four. DualFrobeniusGModule is not copied: GAP'sSMTX.TwistedDualModulecomputes the same module.InfoFormsbecomesInfoRecog_ClassicalNamingat level 2, an unconditionalPrintin QuadraticForm2 becomes anInfomessage, and unused locals are dropped.Fixes #7.
Assisted-by: Generative AI