Repository navigation
Conversation
If M J (M^sigma)^T = lambda J, the caller divides M by the returned s and so needs s^(qq+1) = lambda. When the traces of M and M^-1 were both nonzero, the function returned lambda itself and skipped the coefficient check. GeneratorsWithoutScalarsFrobenius then produced generators preserving no form, and RecogniseClassical named SU(6,5) with scalars on its generators in 2 of 20 runs. Drop the shortcut. With nonzero traces 1 is in I, so the general code already recovers lambda, checks the coefficients and takes the root. Assisted-by: Generative AI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mh-ai/copy-forms-helpers #562 +/- ##
============================================================
+ Coverage 86.52% 86.54% +0.02%
============================================================
Files 50 50
Lines 19748 19745 -3
============================================================
+ Hits 17087 17089 +2
+ Misses 2661 2656 -5
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
M J (M^sigma)^T = lambda J, the caller dividesMby the returnedsand so needss^(qq+1) = lambda. When the traces ofMandM^-1were both nonzero, the function returnedlambdaitself and skipped the coefficient check.GeneratorsWithoutScalarsFrobeniusthen produced generators preserving no form, andRecogniseClassicalfailed to nameSU(6,5)modified with scalars on its generators in 18 of 20 runs.Drop the shortcut. With nonzero traces 1 is in I, so the general code already recovers
lambda, checks the coefficients and takes the root.Assisted-by: Generative AI