Skip to content

Fix the scalar in RECOG.ScalarMultipleFrobenius - #562

Open
fingolfin wants to merge 1 commit into
mh-ai/copy-forms-helpersfrom
mh-ai/fix-RECOG.ScalarMultipleFrobenius
Open

fingolfin wants to merge 1 commit into
mh-ai/copy-forms-helpersfrom
mh-ai/fix-RECOG.ScalarMultipleFrobenius

Conversation

@fingolfin

Copy link
Copy Markdown
Member

If M J (M^sigma)^T = lambda J, the caller divides M by the returned s and so needs s^(qq+1) = lambda. When the traces of M and M^-1 were both nonzero, the function returned lambda itself and skipped the coefficient check. GeneratorsWithoutScalarsFrobenius then produced generators preserving no form, and RecogniseClassical failed to name SU(6,5) modified with scalars on its generators in 18 of 20 runs.

Drop the shortcut. With nonzero traces 1 is in I, so the general code already recovers lambda, checks the coefficients and takes the root.

Assisted-by: Generative AI

If M J (M^sigma)^T = lambda J, the caller divides M by the returned s
and so needs s^(qq+1) = lambda. When the traces of M and M^-1 were
both nonzero, the function returned lambda itself and skipped the
coefficient check. GeneratorsWithoutScalarsFrobenius then produced
generators preserving no form, and RecogniseClassical named SU(6,5)
with scalars on its generators in 2 of 20 runs.

Drop the shortcut. With nonzero traces 1 is in I, so the general code
already recovers lambda, checks the coefficients and takes the root.

Assisted-by: Generative AI
@fingolfin
fingolfin added this pull request to stack #563 November 15, 2026 22:13
@fingolfin fingolfin added topic: naming bug Any bug should have this label, even if it also has a more generic label labels Nov 15, 2026
@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.54%. Comparing base (f0dcb34) to head (441ab5f).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           mh-ai/copy-forms-helpers     #562      +/-   ##
============================================================
+ Coverage                     86.52%   86.54%   +0.02%     
============================================================
  Files                            50       50              
  Lines                         19748    19745       -3     
============================================================
+ Hits                          17087    17089       +2     
+ Misses                         2661     2656       -5     
Files with missing lines Coverage Δ
gap/matrix/classicalforms.gi 95.04% <ø> (+1.32%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Any bug should have this label, even if it also has a more generic label topic: naming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant