-
Notifications
You must be signed in to change notification settings - Fork 175
WIP: gap root path unification #5941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| fi; | ||
| od; | ||
| # Append the new root paths. | ||
| GAPInfo.RootPaths:= Immutable( Concatenation( GAPInfo.RootPaths, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've replaced this now with a loop that uses Add to add each path separately. Various reasons
- the "skip paths already in the list" is more powerful if we do it after ensuring the trailing slash is there
- for HPC-GAP compatibility we may have to switch
GAPInfo.RootPathsfrom a plist to an atomic list, whereAddis supported but notAppend
Anyway this is of course also a natural place to turn relative paths in absolute ones, call realpath, etc. -- but that goes beyond the scope of this PR
| ** returned as a string object. If no file is found then NULL is returned. | ||
| */ | ||
| Char * SyFindGapRootFile(const Char * filename, Char * buf, size_t size) | ||
| Obj SyFindGapRootFile(const Char * filename) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately changing SyFindGapRootFile to return a string object currently clashes with workspace restoring as it is called during that when restoring loaded compiled modules (including kernel extensions).
063917f to
b72d773
Compare
b72d773 to
023b4e0
Compare
|
Looking good so far 🙂 |
This is not yet quite done, but the goal is to ensure that the GAP kernel and library use the same (identical, egal) plist of root paths.
This has multiple benefits:
TODO:
~into$HOMENote that most likely right workspaces are simply broken, but if so I know why and this will be addressed by the above.
Resolves #4675