Skip to content

Conversation

@fingolfin
Copy link
Member

Also remove some now redundant methods.

Before:

gap> m:=RandomMat(256, 256, GF(1000000007));;
gap> mat:=Matrix(IsZmodnZMatrixRep, GF(1000000007), m);;
gap> RankMat(mat)=256; time;
true
170
gap> DeterminantMat(mat); time;
ZmodpZObj( 873487643, 1000000007 )
23982

After:

gap> m:=RandomMat(256, 256, GF(1000000007));;
gap> mat:=Matrix(IsZmodnZMatrixRep, GF(1000000007), m);;
gap> RankMat(mat)=256; time;
true
161
gap> DeterminantMat(mat); time;
ZmodpZObj( 873487643, 1000000007 )
1949

As discussed on #6088

Also remove some now redundant methods.

Before:

    gap> m:=RandomMat(256, 256, GF(1000000007));;
    gap> mat:=Matrix(IsZmodnZMatrixRep, GF(1000000007), m);;
    gap> RankMat(mat)=256; time;
    true
    170
    gap> DeterminantMat(mat); time;
    ZmodpZObj( 873487643, 1000000007 )
    23982

After:

    gap> m:=RandomMat(256, 256, GF(1000000007));;
    gap> mat:=Matrix(IsZmodnZMatrixRep, GF(1000000007), m);;
    gap> RankMat(mat)=256; time;
    true
    161
    gap> DeterminantMat(mat); time;
    ZmodpZObj( 873487643, 1000000007 )
    1949
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

The diffs in the manual examples are harmless, as far as I can tell (the relevant groups are equal, they're just given by different generating sets).

@wilfwilson
Copy link
Member

There's still one pesky harmless failing manual example 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants