[codex] Expose query type filters#2191
Draft
TheLordArgus wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the existing
SearchOpts.typesfilter on the publicqueryoperation so MCP/remote callers can request evidence-only or type-scoped retrieval directly.Root Cause
The lower search layer already supports page-type filtering, but the public
queryop schema did not accept or thread atypesparameter. Remote agents therefore had to retrieve all page types and filter client-side, which is both noisier and less reliable for evidence-only temporal retrieval.Impact
Callers can now ask for queries such as
types: ["source", "conversation"]and avoid mixing raw evidence with derived pages when they need source-grounded answers. The same filter is threaded through the text and image/vector query paths.Changes
typesto the publicqueryoperation params.hybridSearch/ vector search options.Validation
bun test test/e2e/source-isolation-pglite.test.ts