Skip to content

fix(openclaw): quiet native skill triggers#1905

Open
ortonom wants to merge 1 commit into
garrytan:mainfrom
ortonom:fix/openclaw-quiet-native-skill-triggers
Open

fix(openclaw): quiet native skill triggers#1905
ortonom wants to merge 1 commit into
garrytan:mainfrom
ortonom:fix/openclaw-quiet-native-skill-triggers

Conversation

@ortonom

@ortonom ortonom commented Jun 7, 2026

Copy link
Copy Markdown

Summary

  • make OpenClaw native skill descriptions manual/exact-name only
  • prevent ambient Codex/Claude skill routing from auto-triggering nested OpenClaw clones

Test

  • bun test skills/gstack/test/openclaw-native-skills.test.ts

@trunk-io

trunk-io Bot commented Jun 7, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@jbetala7

jbetala7 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

The intent — stop ambient skill routing from auto-firing the nested OpenClaw clones on non-OpenClaw hosts — is reasonable, and the coverage is complete: all four native skills are changed and the existing test/openclaw-native-skills.test.ts still passes. Two things before this lands:

  1. Blanking the description to pure boilerplate diverges from how gstack already does "manual" skills. cso and ios-clean keep a real capability summary and add the manual/convenience note on top, rather than replacing it — e.g. ios-clean: "Remove the DebugBridge SPM package … This is a convenience wrapper —". Suggest keeping a one-line capability summary and appending the exact-name guard, e.g.:
    description: "CEO plan review (OpenClaw-native clone). Manual — invoke only when the user explicitly names gstack-openclaw-ceo-review."
    That kills ambient routing while preserving legibility/discoverability (and any description-based routing inside OpenClaw itself).

  2. No test pins the new behavior. The existing test only asserts name+description are non-empty strings, so a later edit could silently restore the ambient "Use when…" descriptions. Worth adding an assertion that each native skill's description carries the manual guard. (Minor: the PR body's test path is test/openclaw-native-skills.test.ts, not skills/gstack/test/….)

One question to anchor the change: is there a repro/issue showing the ambient mis-trigger actually fires? These four dirs are only referenced by the test, not by the skill-doc generator, so it'd help to confirm which host's router scans openclaw/skills/ and auto-routes them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants