[codex] Fix confirm prompt default regression by Oranquelui · Pull Request #78 · gaureshpai/create-next-quick

Oranquelui · 2026-03-29T10:38:12Z

Summary

avoid duplicating (default: ...) in confirm prompts when the message already includes a default suffix
normalize empty confirm answers to a boolean instead of returning raw string defaults
add regression coverage for both prompt behaviors

Root Cause

The previous fix switched confirm rendering from message to displayMessage, but some callers already embed (default: Yes) in the prompt text. That caused duplicated default text in the rendered confirm line. The confirm handler also returned the raw default value on empty input, which could leak string defaults instead of a boolean.

Validation

COREPACK_ENABLE_AUTO_PIN=0 pnpm exec biome check src/lib/prompts.js src/test/test.js
COREPACK_ENABLE_AUTO_PIN=0 pnpm test

Summary by CodeRabbit

Bug Fixes
- Prevent duplicate "(default: ...)" in confirmation prompts.
- Ensure empty submission resolves to the specified boolean default (string "false" now normalizes to false).
- Improve selected Yes/No label display (redrawn on interactive terminals) for clearer feedback.
Tests
- Added tests covering confirm prompt rendering, default annotation behavior, and boolean normalization.

The Docker prompt's default value is not properly configured, causing it to display incorrectly when the user accepts the default. The default should be 'N' (No) and should be displayed/selected properly. Fixes gaureshpai#74

The confirm prompts now display '(default: Yes)' or '(default: No)' text in addition to the (Y/n) hint, making the default option much clearer. Before: ? Do you want to use TypeScript? (Y/n) After: ? Do you want to use TypeScript? (default: Yes) (Y/n) Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

Make displayMessage use strict boolean check (defaultVal === true) to match confirmHint behavior and prevent contradictory hints when non-boolean truthy values are passed as defaultVal.

Oranquelui · 2026-04-16T03:07:10Z

Checked the latest status: all actual CI test jobs are green on this PR (Node 20.x/22.x across npm, pnpm, and yarn). The only failing status is CodeRabbit, and that failure is Review rate limit exceeded, not a test failure. The PR is still marked MERGEABLE.

itniuma2026 and others added 4 commits March 22, 2026 10:14

fix: : Default docker status is not configured ...

2dce405

The Docker prompt's default value is not properly configured, causing it to display incorrectly when the user accepts the default. The default should be 'N' (No) and should be displayed/selected properly. Fixes gaureshpai#74

Fix boolean check consistency in displayMessage

0c55971

Make displayMessage use strict boolean check (defaultVal === true) to match confirmHint behavior and prevent contradictory hints when non-boolean truthy values are passed as defaultVal.

Fix confirm prompt defaults

a92fa36