feat: add MeepMeshSim for GMSH mesh-based photonic simulations#39
Draft
feat: add MeepMeshSim for GMSH mesh-based photonic simulations#39
Conversation
Add an alternative mesh-based workflow for Meep that mirrors Palace's mesh() → write_config() pattern. Produces a GMSH .msh + mesh_config.json that fully describes a photonic problem. - MeepMeshSim class with geometry/source/domain/solver setters - mesh_config.py writer for JSON problem definition - include_airbox flag on generate_mesh (default False for photonics) - gsim.common.mesh module for solver-agnostic GMSH mesh generation - 21 new tests + notebook demo
Palace mesh modules import shared utilities from gsim.common.mesh instead of duplicating them. Also includes auto-generated api.md.
After fragmentation, identify waveguide boundary faces at each gdsfactory port location and assign them as named surface physical groups (port_<name>). Port metadata (center, width, orientation, layer, z_range) is serialized into mesh_config.json. Also hardcode mesh filename to mesh.msh for consistent cloud runner expectations.
…ation The previous truncation `[:len(tags)]` dropped dielectric volume fragments when fragmentation split boxes into more pieces than the original count. Now layer/metal volume tags are collected first and excluded from dielectric groups, ensuring all fragments are assigned without double-counting. Also improved plot_mesh to render per-group with colors by default, with the largest volume (e.g. cladding) as a transparent wireframe so inner structures like waveguide cores are visible.
Adjacent dielectric boxes of the same material are now merged into a single GMSH box (e.g. box+clad SiO2 → one volume), eliminating coincident faces and sliver tets. Different-material boxes sharing a z-boundary use removeAllDuplicates() to cleanly resolve the shared face. Also adds a regression test verifying box/clad XY consistency, improves the mesh summary in notebooks, and removes the plot_mesh_slice feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MeepMeshSimclass — alternative mesh-based workflow for Meep that mirrors Palace'smesh()→write_config()pattern.msh+mesh_config.jsonthat fully describes a photonic problem (materials, source, monitors, domain, solver)include_airboxflag togenerate_mesh()/add_dielectrics()— defaults toTruefor Palace (RF),Falsefor Meep (photonics)materialfield to volume groups in mesh config JSON for consistency with layer_volumesgsim.common.meshmodule for solver-agnostic GMSH mesh generationTest plan
uv run pytest tests/meep/test_mesh_sim.py -v— 21 new tests passuv run pytest tests/common/test_mesh.py -v— common mesh tests passuv run pytest tests/— all existing tests still passnbs/mesh_ybranch.ipynbproduces.msh+mesh_config.json