Repository navigation
fix(entitlement): no dead Checking… — every terminal state lands somewhere - #166
Merged
Merged
Conversation
…where Mirror of geek-fun/dockit#513. The 'checking' state had three dead ends where the UI spun forever: - a rejected lease dropped the lease and left the view empty — land on the session-expired state (re-login CTA) instead - persistent refresh failure without a cached view left the view empty — land on Unknown with the check-failed copy; a hydrated cached view still degrades to itself (offline contract) - the rethrow on terminal failure was dead semantics — every caller is fire-and-forget, so it only produced unhandled rejections; the action now always resolves with the state on screen - planState reported 'checking' for logged-out visitors — no session, no plan: 'unknown' Also dedupes the console base URL: UserMenu now reuses the exported GEEKFUN_BASE_URL from authService instead of its own copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror of geek-fun/dockit#513. The Checking… state had three dead ends where the UI spun forever — the exact "stuck with no feedback" class it was meant to eliminate.
SESSION_REJECTED)Also:
UserMenureuses the exportedGEEKFUN_BASE_URLfromauthServiceinstead of a duplicate hardcoded constant.Test plan
cargo test412,jest454,eslint+vue-tscclean